Re: [PATCH 2/3] Move ftime to a compatibility symbol

[Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>]

* Szabolcs Nagy via Libc-alpha:

> The 10/15/2020 10:06, Adhemerval Zanella via Libc-alpha wrote:
>> It was made deprecated on 2.31, so it moves to compat symbol after
>> two releases.  It was also removed from exported symbol for riscv32
>> (since ABI will be supported on for 2.33).
>> 
>> Checked on x86_64-linux-gnu and i686-linux-gnu.
>> ---
>>  include/sys/timeb.h                           |  1 -
>>  .../unix/sysv/linux/riscv/rv32/libc.abilist   |  1 -
>>  time/Makefile                                 |  5 +-
>>  time/ftime.c                                  | 19 +++++-
>>  time/sys/timeb.h                              | 44 --------------
>>  time/tst-ftime.c                              | 59 ++++++++++---------
>>  6 files changed, 50 insertions(+), 79 deletions(-)
>>  delete mode 100644 include/sys/timeb.h
>>  delete mode 100644 time/sys/timeb.h
>
> removing sys/timeb.h and ftime breaks several
> spec2006 and spec2017 benchmarks.
>
> which means this header is used in practice,
> sometimes without configure checks.
>
> is there a reason it cannot be supported?

I think we should minimize the number of time-related symbols, in case
we ever want to provide a dual ABI (with multiple time_t sizes).

SPEC isn't going to change, so I don't think it makes sense to wait for
it getting fixed.

Thanks,
Florian
-- 
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill