From: Junio C Hamano <gitster@pobox.com>
To: "Kashav Madan via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Johannes Altmanninger <aclopte@gmail.com>,
Eric Sunshine <sunshine@sunshineco.com>,
kashav madan <kshvmdn@gmail.com>
Subject: Re: [PATCH v3 1/4] bisect--helper: normalize format string of yes/no prompts
Date: Thu, 16 Dec 2021 13:39:56 -0800 [thread overview]
Message-ID: <xmqqy24k8c0j.fsf@gitster.g> (raw)
In-Reply-To: <e7672e70cc937ef3aaab9a36199470e01f6676a8.1639678735.git.gitgitgadget@gmail.com> (Kashav Madan via GitGitGadget's message of "Thu, 16 Dec 2021 18:18:51 +0000")
"Kashav Madan via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Kashav Madan <kshvmdn@gmail.com>
>
> Both callers of git_prompt in bisect--helper.c ask the user for yes/no
> confirmation. They both place the question mark after the choices,
> however this is inconsistent with how most UNIX-y tools do it. Update
> the format string to exclude the choices from the question.
Is there somewhere that the claim can be confirmed? I am not having
much luck with queries like
https://www.google.com/search?q=prompt+question+mark+and+choices
that gave https://home.csulb.edu/~murdock/choice.html the most
relevant page X-<.
I personally do not think this step is worth doing, but in any case,
NEVER touch po/* directory when you are updating code and strings in
the code. It is something our i18n coordinator will do at certain
point in the release cycle.
next prev parent reply other threads:[~2021-12-16 21:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 21:41 [PATCH] help: add space after autocorrect prompt kashav madan via GitGitGadget
2021-12-15 22:32 ` Junio C Hamano
2021-12-16 6:27 ` Johannes Altmanninger
2021-12-16 15:55 ` Eric Sunshine
2021-12-16 21:32 ` Junio C Hamano
2021-12-15 22:58 ` [PATCH v2] help: make auto-correction prompt more consistent kashav madan via GitGitGadget
2021-12-16 3:12 ` Junio C Hamano
2021-12-16 18:18 ` [PATCH v3 0/4] normalize format of yes/no prompts kashav madan via GitGitGadget
2021-12-16 18:18 ` [PATCH v3 1/4] bisect--helper: normalize format string " Kashav Madan via GitGitGadget
2021-12-16 21:39 ` Junio C Hamano [this message]
2021-12-16 21:49 ` Junio C Hamano
2021-12-16 18:18 ` [PATCH v3 2/4] clean: normalize format string of yes/no prompt Kashav Madan via GitGitGadget
2021-12-16 18:18 ` [PATCH v3 3/4] add-patch: " Kashav Madan via GitGitGadget
2021-12-16 18:18 ` [PATCH v3 4/4] help: make auto-correction prompt more consistent Kashav Madan via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy24k8c0j.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=aclopte@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=kshvmdn@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).