Re: [PATCH] help: add space after autocorrect prompt

[Johannes Altmanninger <aclopte@gmail.com>]

On Wed, Dec 15, 2021 at 02:32:36PM -0800, Junio C Hamano wrote:
> "kashav madan via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
> > From: Kashav Madan <kshvmdn@gmail.com>
> >
> > Signed-off-by: Kashav Madan <kshvmdn@gmail.com>
> > ---
> >     help: add space after autocorrect prompt
> 
> The patch looks OK-ish, but let's make sure.  We will find what we
> should write in the log message while doing so.
> 
> If you look at the output from
> 
>     $ git grep -C2 git_prompt \*.c
> 
> you'll notice that existing message given to git_prompt look like
> these:
> 
>     yesno = git_prompt(_("Are you sure [Y/n]? "), PROMPT_ECHO);
> 
>     yesno = git_prompt(_("Do you want me to do it for you "
>                          "[Y/n]? "), PROMPT_ECHO);
> 
>     strbuf_addf(&msg, _("Run '%s' instead? (y/N)"), assumed);
>     answer = git_prompt(msg.buf, PROMPT_ECHO);
> 
> The last one is what you are touching in this patch.
> 
> There is another one in credential.c that asks not just a single
> yes/no answer, so it is justifiably different from all the others,
> but the one you noticed is different from what we see above in three
> points:
> 
>  - It does not leave a SP before where the end-user input goes;
>  - It append (y/N) _after_ question mark;

I actually prefer this one;

	Run 'status' instead? [y/N] 

sounds better than

	Run 'status' instead [y/N]? 

but that's not a strong opinion.