git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Altmanninger <aclopte@gmail.com>
Cc: kashav madan via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, kashav madan <kshvmdn@gmail.com>
Subject: Re: [PATCH] help: add space after autocorrect prompt
Date: Thu, 16 Dec 2021 13:32:27 -0800	[thread overview]
Message-ID: <xmqq35ms9qxg.fsf@gitster.g> (raw)
In-Reply-To: <20211216062709.b4tcagi6qcqhasrh@gmail.com> (Johannes Altmanninger's message of "Thu, 16 Dec 2021 07:27:09 +0100")

Johannes Altmanninger <aclopte@gmail.com> writes:

>>  - It does not leave a SP before where the end-user input goes;
>>  - It append (y/N) _after_ question mark;
>
> I actually prefer this one;
>
> 	Run 'status' instead? [y/N] 
>
> sounds better than
>
> 	Run 'status' instead [y/N]? 
>
> but that's not a strong opinion.

It is fine to have your own preference, but we are discussing to
make the three, two of which use "[choices]? " while only one uses
"? (choices)", consistent.  

So I'd prefer to see us turn the odd man out to do "[choices]? "
first.  Adjusting to your personal preference can be proposed after
the dust settles for the consistency fix.

Thanks.

  parent reply	other threads:[~2021-12-16 21:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-15 21:41 [PATCH] help: add space after autocorrect prompt kashav madan via GitGitGadget
2021-12-15 22:32 ` Junio C Hamano
2021-12-16  6:27   ` Johannes Altmanninger
2021-12-16 15:55     ` Eric Sunshine
2021-12-16 21:32     ` Junio C Hamano [this message]
2021-12-15 22:58 ` [PATCH v2] help: make auto-correction prompt more consistent kashav madan via GitGitGadget
2021-12-16  3:12   ` Junio C Hamano
2021-12-16 18:18   ` [PATCH v3 0/4] normalize format of yes/no prompts kashav madan via GitGitGadget
2021-12-16 18:18     ` [PATCH v3 1/4] bisect--helper: normalize format string " Kashav Madan via GitGitGadget
2021-12-16 21:39       ` Junio C Hamano
2021-12-16 21:49         ` Junio C Hamano
2021-12-16 18:18     ` [PATCH v3 2/4] clean: normalize format string of yes/no prompt Kashav Madan via GitGitGadget
2021-12-16 18:18     ` [PATCH v3 3/4] add-patch: " Kashav Madan via GitGitGadget
2021-12-16 18:18     ` [PATCH v3 4/4] help: make auto-correction prompt more consistent Kashav Madan via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq35ms9qxg.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=aclopte@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=kshvmdn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).