From: Eric Sunshine <sunshine@sunshineco.com>
To: Johannes Altmanninger <aclopte@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
kashav madan via GitGitGadget <gitgitgadget@gmail.com>,
Git List <git@vger.kernel.org>, kashav madan <kshvmdn@gmail.com>
Subject: Re: [PATCH] help: add space after autocorrect prompt
Date: Thu, 16 Dec 2021 10:55:09 -0500 [thread overview]
Message-ID: <CAPig+cQ9zFE+83e4fwxLfL18Pf5=SOoDKD7RqhmJ3DmYUDKfow@mail.gmail.com> (raw)
In-Reply-To: <20211216062709.b4tcagi6qcqhasrh@gmail.com>
On Thu, Dec 16, 2021 at 6:18 AM Johannes Altmanninger <aclopte@gmail.com> wrote:
> On Wed, Dec 15, 2021 at 02:32:36PM -0800, Junio C Hamano wrote:
> > you'll notice that existing message given to git_prompt look like
> > these:
> >
> > yesno = git_prompt(_("Are you sure [Y/n]? "), PROMPT_ECHO);
> >
> > yesno = git_prompt(_("Do you want me to do it for you "
> > "[Y/n]? "), PROMPT_ECHO);
> >
> > strbuf_addf(&msg, _("Run '%s' instead? (y/N)"), assumed);
> > answer = git_prompt(msg.buf, PROMPT_ECHO);
> >
> > - It does not leave a SP before where the end-user input goes;
> > - It append (y/N) _after_ question mark;
>
> I actually prefer this one;
>
> Run 'status' instead? [y/N]
>
> sounds better than
>
> Run 'status' instead [y/N]?
>
> but that's not a strong opinion.
For what it's worth, I also find "Run 'status' instead? [y/N]" more
sensible, and (at least based upon memory) it also seems to be the
typical way it's done in other software (including software I've
written). That said, it's a very minor point which needn't hold up the
patch if kashav isn't interested in redoing this as a single patch
which normalizes all callers to use a common format.
next prev parent reply other threads:[~2021-12-16 15:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 21:41 [PATCH] help: add space after autocorrect prompt kashav madan via GitGitGadget
2021-12-15 22:32 ` Junio C Hamano
2021-12-16 6:27 ` Johannes Altmanninger
2021-12-16 15:55 ` Eric Sunshine [this message]
2021-12-16 21:32 ` Junio C Hamano
2021-12-15 22:58 ` [PATCH v2] help: make auto-correction prompt more consistent kashav madan via GitGitGadget
2021-12-16 3:12 ` Junio C Hamano
2021-12-16 18:18 ` [PATCH v3 0/4] normalize format of yes/no prompts kashav madan via GitGitGadget
2021-12-16 18:18 ` [PATCH v3 1/4] bisect--helper: normalize format string " Kashav Madan via GitGitGadget
2021-12-16 21:39 ` Junio C Hamano
2021-12-16 21:49 ` Junio C Hamano
2021-12-16 18:18 ` [PATCH v3 2/4] clean: normalize format string of yes/no prompt Kashav Madan via GitGitGadget
2021-12-16 18:18 ` [PATCH v3 3/4] add-patch: " Kashav Madan via GitGitGadget
2021-12-16 18:18 ` [PATCH v3 4/4] help: make auto-correction prompt more consistent Kashav Madan via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cQ9zFE+83e4fwxLfL18Pf5=SOoDKD7RqhmJ3DmYUDKfow@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=aclopte@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=kshvmdn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).