From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Jean-Noël Avila" <jn.avila@free.fr>,
"Jiang Xin" <worldhello.net@gmail.com>,
"Git List" <git@vger.kernel.org>
Subject: Re: [PATCH] PRItime: wrap PRItime for better l10n compatibility
Date: Tue, 25 Jul 2017 13:46:35 -0700 [thread overview]
Message-ID: <xmqqfudkutw4.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1.1707251219480.4271@virtualbox> (Johannes Schindelin's message of "Tue, 25 Jul 2017 12:20:47 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Hi Junio,
>
> On Sat, 22 Jul 2017, Junio C Hamano wrote:
>
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>>
>> > On Fri, 21 Jul 2017, Junio C Hamano wrote:
>> >
>> >> Jean-Noël Avila <jn.avila@free.fr> writes:
>> >>
>> >> > Le 20/07/2017 à 20:57, Junio C Hamano a écrit :
>> >> >>
>> >> >> + git diff --quiet HEAD && git diff --quiet --cached
>> >> >> +
>> >> >> + @for s in $(LOCALIZED_C) $(LOCALIZED_SH) $(LOCALIZED_PERL); \
>> >> >
>> >> > Does PRIuMAX make sense for perl and sh files?
>> >>
>> >> Not really; I did this primarily because I would prefer to keep
>> >> things consistent, anticipating there may be some other things we
>> >> need to replace before running gettext(1) for other reasons later.
>> >
>> > It would add unnecessary churn, too, to add those specific exclusions and
>> > make things inconsistent: the use of PRItime in Perl or shell scripts
>> > would already make those scripts barf. And if it is unnecessary churn...
>> > let's not do it?
>>
>> Sorry, but I cannot quite tell if you are in favor of limiting the
>> set of source files that go through the sed substitution (because we
>> know PRIuMAX is just as nonsensical as PRItime in perl and shell
>> source), or if you are in favor of keeping the patch as-is (because
>> changing the set of source files is a churn and substitutions would
>> not hurt)?
>
> I was in favor of keeping the simplest strategy: simply cover all files,
> including Perl and Unix shell scripts. It would not bring any benefit to
> exclude them.
OK. I actually was OK to limit the potential damage to C sources,
but it does not matter that much in the bigger picture.
next prev parent reply other threads:[~2017-07-25 20:46 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-15 5:06 [L10N] Kickoff of translation for Git 2.14.0 round 1 Jiang Xin
2017-07-15 19:30 ` Jean-Noël Avila
2017-07-17 0:56 ` Jiang Xin
2017-07-17 16:06 ` Johannes Schindelin
2017-07-18 1:28 ` Jiang Xin
2017-07-17 15:23 ` [PATCH] PRItime: wrap PRItime for better l10n compatibility Jiang Xin
2017-07-17 17:10 ` Junio C Hamano
2017-07-18 1:33 ` Jiang Xin
2017-07-18 17:35 ` Junio C Hamano
2017-07-19 0:57 ` Jiang Xin
2017-07-19 13:25 ` Johannes Schindelin
2017-07-19 21:32 ` Junio C Hamano
2017-07-19 23:03 ` Junio C Hamano
2017-07-20 18:19 ` Junio C Hamano
2017-07-20 18:24 ` Junio C Hamano
2017-07-20 18:57 ` Junio C Hamano
2017-07-21 14:38 ` Jean-Noël Avila
2017-07-21 14:54 ` Junio C Hamano
2017-07-22 11:21 ` Johannes Schindelin
2017-07-22 15:53 ` Junio C Hamano
2017-07-25 10:20 ` Johannes Schindelin
2017-07-25 20:46 ` Junio C Hamano [this message]
2017-07-21 22:17 ` Jiang Xin
2017-07-21 22:40 ` Junio C Hamano
2017-07-21 23:13 ` Jiang Xin
2017-07-21 23:34 ` Junio C Hamano
2017-07-22 0:43 ` Jiang Xin
2017-07-22 0:52 ` [PATCH] Makefile: generate pot file using a tweaked version of xgettext Jiang Xin
2017-07-22 2:44 ` [PATCH] PRItime: wrap PRItime for better l10n compatibility Junio C Hamano
2017-07-22 11:28 ` Johannes Schindelin
2017-07-22 15:48 ` Junio C Hamano
2017-07-24 1:50 ` Jiang Xin
2017-07-25 10:22 ` Johannes Schindelin
2017-07-25 20:49 ` Junio C Hamano
2017-07-24 1:38 ` Jiang Xin
2017-07-24 19:09 ` Junio C Hamano
2017-07-25 10:25 ` Johannes Schindelin
2017-07-23 2:33 ` Jean-Noël AVILA
2017-07-23 21:54 ` Junio C Hamano
2017-07-24 2:02 ` Jiang Xin
2017-07-24 19:10 ` Junio C Hamano
2017-07-22 17:02 ` [L10N] Kickoff of translation for Git 2.14.0 round 1 Kaartic Sivaraam
2017-07-23 2:43 ` Jean-Noël Avila
2017-07-19 5:44 ` Jordi Mas
2017-07-20 0:50 ` Jiang Xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfudkutw4.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=jn.avila@free.fr \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).