From: Jiang Xin <worldhello.net@gmail.com>
To: "Jean-Noël Avila" <jn.avila@free.fr>
Cc: "Alexander Shopov" <ash@kambanaria.org>,
"Jordi Mas" <jmas@softcatala.org>,
"Ralf Thielow" <ralf.thielow@gmail.com>,
"Marco Paolone" <marcopaolone@gmail.com>,
"Changwoo Ryu" <cwryu@debian.org>,
"Vasco Almeida" <vascomalmeida@sapo.pt>,
"Dimitriy Ryazantcev" <DJm00n@mail.ru>,
"Peter Krefting" <peter@softwolves.pp.se>,
"Trần Ngọc Quân" <vnwildman@gmail.com>,
"Nelson Martell" <nelson6e65@gmail.com>,
"Brian Gesiak" <modocache@gmail.com>, m4sk1n <m4sk1n@o2.pl>,
Vitaly <vitaly.gorodetsky@gmail.com>,
"Ying Ruei Liang (KK)" <thumbd03803@gmail.com>,
babycaseny <babycaseny@gmail.com>,
"Johannes Schindelin" <johannes.schindelin@gmx.de>,
"Kaartic Sivaraam" <kaarticsivaraam91196@gmail.com>,
"Git List" <git@vger.kernel.org>
Subject: Re: [L10N] Kickoff of translation for Git 2.14.0 round 1
Date: Mon, 17 Jul 2017 08:56:53 +0800 [thread overview]
Message-ID: <CANYiYbGyCbzxPuiUUD5XBo2zAfKiZ9XQcEu_=s8XxsMGP1J4Og@mail.gmail.com> (raw)
In-Reply-To: <249ac6f8-af3c-4b20-5bf0-87a82866cc7a@free.fr>
2017-07-16 3:30 GMT+08:00 Jean-Noël Avila <jn.avila@free.fr>:
>
>
> A few remarks on i18n:
>
> * commit cb71f8bdb5 ("PRItime: introduce a new "printf format" for
> timestamps") does not play well with i18n framework. The static string
> concatenation cannot be correctly interpreted by msgmerge. I don't know
> how we can combine variable format indicators with translatable strings.
>
We can add a new wrapper for raw timestamp like:
+const char *format_raw_time(timestamp_t time)
+{
+ static struct strbuf time_buf = STRBUF_INIT;
+
+ strbuf_reset(&time_buf);
+ strbuf_addf(&time_buf, "%"PRItime, time);
+ return time_buf.buf;
+}
, and replace macro PRItime in i18n messages with format_raw_time
wrapper, like this:
- strbuf_addf(&sb, Q_("%"PRItime" year",
"%"PRItime" years", years), years);
+ strbuf_addf(&sb, Q_("%s year", "%s years",
years), format_raw_time(years));
--
Jiang Xin
next prev parent reply other threads:[~2017-07-17 0:56 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-15 5:06 [L10N] Kickoff of translation for Git 2.14.0 round 1 Jiang Xin
2017-07-15 19:30 ` Jean-Noël Avila
2017-07-17 0:56 ` Jiang Xin [this message]
2017-07-17 16:06 ` Johannes Schindelin
2017-07-18 1:28 ` Jiang Xin
2017-07-17 15:23 ` [PATCH] PRItime: wrap PRItime for better l10n compatibility Jiang Xin
2017-07-17 17:10 ` Junio C Hamano
2017-07-18 1:33 ` Jiang Xin
2017-07-18 17:35 ` Junio C Hamano
2017-07-19 0:57 ` Jiang Xin
2017-07-19 13:25 ` Johannes Schindelin
2017-07-19 21:32 ` Junio C Hamano
2017-07-19 23:03 ` Junio C Hamano
2017-07-20 18:19 ` Junio C Hamano
2017-07-20 18:24 ` Junio C Hamano
2017-07-20 18:57 ` Junio C Hamano
2017-07-21 14:38 ` Jean-Noël Avila
2017-07-21 14:54 ` Junio C Hamano
2017-07-22 11:21 ` Johannes Schindelin
2017-07-22 15:53 ` Junio C Hamano
2017-07-25 10:20 ` Johannes Schindelin
2017-07-25 20:46 ` Junio C Hamano
2017-07-21 22:17 ` Jiang Xin
2017-07-21 22:40 ` Junio C Hamano
2017-07-21 23:13 ` Jiang Xin
2017-07-21 23:34 ` Junio C Hamano
2017-07-22 0:43 ` Jiang Xin
2017-07-22 0:52 ` [PATCH] Makefile: generate pot file using a tweaked version of xgettext Jiang Xin
2017-07-22 2:44 ` [PATCH] PRItime: wrap PRItime for better l10n compatibility Junio C Hamano
2017-07-22 11:28 ` Johannes Schindelin
2017-07-22 15:48 ` Junio C Hamano
2017-07-24 1:50 ` Jiang Xin
2017-07-25 10:22 ` Johannes Schindelin
2017-07-25 20:49 ` Junio C Hamano
2017-07-24 1:38 ` Jiang Xin
2017-07-24 19:09 ` Junio C Hamano
2017-07-25 10:25 ` Johannes Schindelin
2017-07-23 2:33 ` Jean-Noël AVILA
2017-07-23 21:54 ` Junio C Hamano
2017-07-24 2:02 ` Jiang Xin
2017-07-24 19:10 ` Junio C Hamano
2017-07-22 17:02 ` [L10N] Kickoff of translation for Git 2.14.0 round 1 Kaartic Sivaraam
2017-07-23 2:43 ` Jean-Noël Avila
2017-07-19 5:44 ` Jordi Mas
2017-07-20 0:50 ` Jiang Xin
-- strict thread matches above, loose matches on Subject: below --
2017-07-18 3:27 Kaartic Sivaraam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANYiYbGyCbzxPuiUUD5XBo2zAfKiZ9XQcEu_=s8XxsMGP1J4Og@mail.gmail.com' \
--to=worldhello.net@gmail.com \
--cc=DJm00n@mail.ru \
--cc=ash@kambanaria.org \
--cc=babycaseny@gmail.com \
--cc=cwryu@debian.org \
--cc=git@vger.kernel.org \
--cc=jmas@softcatala.org \
--cc=jn.avila@free.fr \
--cc=johannes.schindelin@gmx.de \
--cc=kaarticsivaraam91196@gmail.com \
--cc=m4sk1n@o2.pl \
--cc=marcopaolone@gmail.com \
--cc=modocache@gmail.com \
--cc=nelson6e65@gmail.com \
--cc=peter@softwolves.pp.se \
--cc=ralf.thielow@gmail.com \
--cc=thumbd03803@gmail.com \
--cc=vascomalmeida@sapo.pt \
--cc=vitaly.gorodetsky@gmail.com \
--cc=vnwildman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).