From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git-for-windows@googlegroups.com, git@vger.kernel.org,
git-packagers@googlegroups.com,
Ariadne Conill <ariadne@dereferenced.org>
Subject: Re: Git for Windows v2.23.0-rc0, was Re: [ANNOUNCE] Git v2.23.0-rc0
Date: Thu, 01 Aug 2019 14:46:29 -0700 [thread overview]
Message-ID: <xmqqa7csmudm.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190801213638.GA30522@sigill.intra.peff.net> (Jeff King's message of "Thu, 1 Aug 2019 17:36:39 -0400")
Jeff King <peff@peff.net> writes:
>> + if (mailmap < 0)
>> mailmap = 0;
>> - }
>
> This should be "mailmap = 1" to match the commit message, no? (Which
> also implies we may want a new test).
Gaa, of course.
> I'd also be OK with leaving it at "0" for now, making a note of the
> upcoming change in the release notes, and flipping it _next_ time. But
> IMHO we don't need to be that conservative (and I share your pessimism
> that enough people actually read the release notes to merit that kind of
> advance notice).
I'd actually think s/need to be/get any benefit from being/; it
would be wasted effort to be extra careful, and any way we cut it,
there will always be people who complain.
next prev parent reply other threads:[~2019-08-01 21:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 21:49 [ANNOUNCE] Git v2.23.0-rc0 Junio C Hamano
2019-07-31 12:43 ` Git for Windows v2.23.0-rc0, was " Johannes Schindelin
2019-07-31 23:18 ` Jeff King
2019-08-01 0:21 ` Jonathan Nieder
2019-08-01 0:37 ` Ariadne Conill
2019-08-01 1:00 ` Jeff King
2019-08-01 1:14 ` Jonathan Nieder
2019-08-01 1:38 ` Ariadne Conill
2019-08-01 2:53 ` Jeff King
2019-08-01 3:21 ` Junio C Hamano
2019-08-01 4:54 ` Ariadne Conill
2019-08-01 21:39 ` Johannes Schindelin
2019-08-01 15:45 ` Junio C Hamano
2019-08-01 16:12 ` Ariadne Conill
2019-08-01 21:36 ` Jeff King
2019-08-01 21:46 ` Junio C Hamano [this message]
2019-08-01 21:54 ` Junio C Hamano
2019-08-01 22:18 ` Todd Zullinger
2019-08-02 2:27 ` Jonathan Nieder
2019-08-02 16:53 ` Junio C Hamano
2019-08-02 18:35 ` Jeff King
2019-08-01 1:04 ` [git-for-windows] " Bryan Turner
2019-08-01 21:40 ` Johannes Schindelin
2019-08-01 14:12 ` [PATCH] RelNotes/2.23.0: fix a few typos and other minor issues Martin Ågren
2019-08-01 15:56 ` Junio C Hamano
2019-08-01 15:57 ` Junio C Hamano
2019-08-01 19:28 ` Martin Ågren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa7csmudm.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=ariadne@dereferenced.org \
--cc=git-for-windows@googlegroups.com \
--cc=git-packagers@googlegroups.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).