git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Ariadne Conill <ariadne@dereferenced.org>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Junio C Hamano <gitster@pobox.com>,
	git-for-windows@googlegroups.com,
	Git Mailing List <git@vger.kernel.org>,
	git-packagers@googlegroups.com
Subject: Re: Git for Windows v2.23.0-rc0, was Re: [ANNOUNCE] Git v2.23.0-rc0
Date: Wed, 31 Jul 2019 22:53:42 -0400	[thread overview]
Message-ID: <20190801025342.GA7102@sigill.intra.peff.net> (raw)
In-Reply-To: <CAAOiGNwDV3LNGRVPQN6DgES6raG76u-rW0nBuw=i2oHTibVSPg@mail.gmail.com>

On Wed, Jul 31, 2019 at 08:38:14PM -0500, Ariadne Conill wrote:

> > Something like:
> >
> >   Author: A U Thor <author@example.com>
> >   Original-Author: I M Mailmapped <orig@example.com>
> >
> > gives even more information while leaving the "Author:" line untouched.
> > But in introducing a new line, it may also be breaking somebody.
> 
> It also makes this entire exercise completely moot because not only
> does it deadname the contributor, it discloses that it is deadnaming
> the contributor while also telling you who they are now, which is even
> worse than the current behaviour.  The purpose of this exercise is to
> ensure that users have the *current* contact information of the
> contributor by default, including their current name and e-mail.  My
> entire goal behind transitioning this config default is to ensure that
> git respects *present* identity information by default, while giving
> access to the raw identity data in cases where it makes sense to do so
> (such as historical research or whatever).  I don't really wish for
> git to remind me of my previous identity while browsing through
> historical git logs.  I also don't think most people care about the
> previous identity data of contributors -- in most cases, if you're
> looking up a commit's author, you're doing so because you intend to
> ask them a question about the commit, and so, having the most current
> identity data available is what actually makes sense.

Fair enough. My thinking was just that it would make it clear to
somebody who wasn't expecting the mailmap to be used what was going on:
they would have seen "orig" in the old output, but now they are seeing
"author". But I agree that most people wouldn't even _care_, and the
orig name is just garbage in most cases.

I had been thinking it would be a temporary measure during the
transition period, but it probably isn't even worth the hassle and
confusion it would cause during that period.

By the way, we've been talking mostly about output in this thread. One
thing that did catch me a little by surprise is that "--author", etc,
will now use the mailmap by default, too. Which I think makes perfect
sense, but when looking for my own mailmapped entries to run some
examples on, I was surprised at first that "git log
--author=peff@github.com" didn't find anything.

But aside from experimenting with this mailmap feature, I cannot think
of a single time in the last decade I would have cared about that
distinction (and in fact, most of the time I would be searching for my
own commits by my mailmapped address, and would have preferred they be
found in that group).

-Peff

  reply	other threads:[~2019-08-01  2:53 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-29 21:49 [ANNOUNCE] Git v2.23.0-rc0 Junio C Hamano
2019-07-31 12:43 ` Git for Windows v2.23.0-rc0, was " Johannes Schindelin
2019-07-31 23:18   ` Jeff King
2019-08-01  0:21     ` Jonathan Nieder
2019-08-01  0:37       ` Ariadne Conill
2019-08-01  1:00       ` Jeff King
2019-08-01  1:14         ` Jonathan Nieder
2019-08-01  1:38         ` Ariadne Conill
2019-08-01  2:53           ` Jeff King [this message]
2019-08-01  3:21         ` Junio C Hamano
2019-08-01  4:54           ` Ariadne Conill
2019-08-01 21:39             ` Johannes Schindelin
2019-08-01 15:45       ` Junio C Hamano
2019-08-01 16:12         ` Ariadne Conill
2019-08-01 21:36         ` Jeff King
2019-08-01 21:46           ` Junio C Hamano
2019-08-01 21:54             ` Junio C Hamano
2019-08-01 22:18               ` Todd Zullinger
2019-08-02  2:27         ` Jonathan Nieder
2019-08-02 16:53           ` Junio C Hamano
2019-08-02 18:35             ` Jeff King
2019-08-01  1:04   ` [git-for-windows] " Bryan Turner
2019-08-01 21:40     ` Johannes Schindelin
2019-08-01 14:12 ` [PATCH] RelNotes/2.23.0: fix a few typos and other minor issues Martin Ågren
2019-08-01 15:56   ` Junio C Hamano
2019-08-01 15:57   ` Junio C Hamano
2019-08-01 19:28     ` Martin Ågren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190801025342.GA7102@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=ariadne@dereferenced.org \
    --cc=git-for-windows@googlegroups.com \
    --cc=git-packagers@googlegroups.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).