From: Jeff King <peff@peff.net> To: Junio C Hamano <gitster@pobox.com> Cc: Jonathan Nieder <jrnieder@gmail.com>, Johannes Schindelin <Johannes.Schindelin@gmx.de>, git-for-windows@googlegroups.com, git@vger.kernel.org, git-packagers@googlegroups.com, Ariadne Conill <ariadne@dereferenced.org> Subject: Re: Git for Windows v2.23.0-rc0, was Re: [ANNOUNCE] Git v2.23.0-rc0 Date: Thu, 1 Aug 2019 17:36:39 -0400 Message-ID: <20190801213638.GA30522@sigill.intra.peff.net> (raw) In-Reply-To: <xmqqlfwcopn1.fsf@gitster-ct.c.googlers.com> On Thu, Aug 01, 2019 at 08:45:54AM -0700, Junio C Hamano wrote: > While I think "revert to hardcoded default" may be a good idea, I do > not think the hardcoded default you implemented that changes the > behaviour based on the output destination makes much sense. If I > want to eradicate junkio@cox.net from my paged/interactive output, I > want to eradicate it also in the output piped to the script I use > for authorship stats. > > I suspect that you may have misread the "is interactive" bit in the > original; that was used only to decide if we are going to warn. Yeah, I wondered about the same misreading when I read the response in: https://public-inbox.org/git/20190801011448.GB176307@google.com/ > Anyway, how about this much simplified version? Yes, this is what I was thinking of in my earlier responses, but... > @@ -214,12 +204,8 @@ static void cmd_log_init_finish(int argc, const char **argv, const char *prefix, > memset(&w, 0, sizeof(w)); > userformat_find_requirements(NULL, &w); > > - if (mailmap < 0) { > - if (session_is_interactive() && !rev->pretty_given) > - warning("%s\n", _(warn_unspecified_mailmap_msg)); > - > + if (mailmap < 0) > mailmap = 0; > - } This should be "mailmap = 1" to match the commit message, no? (Which also implies we may want a new test). I'd also be OK with leaving it at "0" for now, making a note of the upcoming change in the release notes, and flipping it _next_ time. But IMHO we don't need to be that conservative (and I share your pessimism that enough people actually read the release notes to merit that kind of advance notice). -Peff
next prev parent reply other threads:[~2019-08-01 21:36 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-29 21:49 Junio C Hamano 2019-07-31 12:43 ` Git for Windows v2.23.0-rc0, was " Johannes Schindelin 2019-07-31 23:18 ` Jeff King 2019-08-01 0:21 ` Jonathan Nieder 2019-08-01 0:37 ` Ariadne Conill 2019-08-01 1:00 ` Jeff King 2019-08-01 1:14 ` Jonathan Nieder 2019-08-01 1:38 ` Ariadne Conill 2019-08-01 2:53 ` Jeff King 2019-08-01 3:21 ` Junio C Hamano 2019-08-01 4:54 ` Ariadne Conill 2019-08-01 21:39 ` Johannes Schindelin 2019-08-01 15:45 ` Junio C Hamano 2019-08-01 16:12 ` Ariadne Conill 2019-08-01 21:36 ` Jeff King [this message] 2019-08-01 21:46 ` Junio C Hamano 2019-08-01 21:54 ` Junio C Hamano 2019-08-01 22:18 ` Todd Zullinger 2019-08-02 2:27 ` Jonathan Nieder 2019-08-02 16:53 ` Junio C Hamano 2019-08-02 18:35 ` Jeff King 2019-08-01 1:04 ` [git-for-windows] " Bryan Turner 2019-08-01 21:40 ` Johannes Schindelin 2019-08-01 14:12 ` [PATCH] RelNotes/2.23.0: fix a few typos and other minor issues Martin Ågren 2019-08-01 15:56 ` Junio C Hamano 2019-08-01 15:57 ` Junio C Hamano 2019-08-01 19:28 ` Martin Ågren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190801213638.GA30522@sigill.intra.peff.net \ --to=peff@peff.net \ --cc=Johannes.Schindelin@gmx.de \ --cc=ariadne@dereferenced.org \ --cc=git-for-windows@googlegroups.com \ --cc=git-packagers@googlegroups.com \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=jrnieder@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ git@vger.kernel.org public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for the project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git