git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
	git-for-windows@googlegroups.com, git@vger.kernel.org,
	git-packagers@googlegroups.com
Subject: Re: Git for Windows v2.23.0-rc0, was Re: [ANNOUNCE] Git v2.23.0-rc0
Date: Wed, 31 Jul 2019 19:18:48 -0400	[thread overview]
Message-ID: <20190731231848.GC1933@sigill.intra.peff.net> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1907311440130.21907@tvgsbejvaqbjf.bet>

On Wed, Jul 31, 2019 at 02:43:10PM +0200, Johannes Schindelin wrote:

> And a corresponding Git for Windows v2.23.0-rc0 can be found here:
> 
> https://github.com/git-for-windows/git/releases/tag/v2.23.0-rc0.windows.1
> 
> Please test!
> 
> One (slightly annoying) issue I found already is that a `git log` will
> print out a blurb about `log.mailmap`, but most of the time, you cannot
> see it because the actual output of `git log` is shown in the pager.
> 
> I plan on working around this by setting `log.mailmap = true` in Git for
> Windows' system config.

I too was annoyed recently by that warning (I set the config to squelch
it, but I'm sure it will pop up again for me in some other context where
I don't have my usual config).

Setting log.mailmap=true in the distributed system seems to defeat the
purpose, though, doesn't it? The point is for users to see the warning
and adjust their expectations, but with your plan they would never see
it.

I think part of what my annoyance is responding to (and your willingness
to just squelch this for everybody) is that switching this particular
default isn't really that big a deal, that it requires annoying people
on every single "git log" invocation. Perhaps we would be better
squelching it entirely and just putting a mention in the release notes.

I know that having been burned by the dashed-form deprecation long ago,
Junio is hesitant to rely on release notes. But it really seems like
this is a pretty minor change, and the solution is worse than the
problem.

-Peff

  reply	other threads:[~2019-07-31 23:18 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-29 21:49 [ANNOUNCE] Git v2.23.0-rc0 Junio C Hamano
2019-07-31 12:43 ` Git for Windows v2.23.0-rc0, was " Johannes Schindelin
2019-07-31 23:18   ` Jeff King [this message]
2019-08-01  0:21     ` Jonathan Nieder
2019-08-01  0:37       ` Ariadne Conill
2019-08-01  1:00       ` Jeff King
2019-08-01  1:14         ` Jonathan Nieder
2019-08-01  1:38         ` Ariadne Conill
2019-08-01  2:53           ` Jeff King
2019-08-01  3:21         ` Junio C Hamano
2019-08-01  4:54           ` Ariadne Conill
2019-08-01 21:39             ` Johannes Schindelin
2019-08-01 15:45       ` Junio C Hamano
2019-08-01 16:12         ` Ariadne Conill
2019-08-01 21:36         ` Jeff King
2019-08-01 21:46           ` Junio C Hamano
2019-08-01 21:54             ` Junio C Hamano
2019-08-01 22:18               ` Todd Zullinger
2019-08-02  2:27         ` Jonathan Nieder
2019-08-02 16:53           ` Junio C Hamano
2019-08-02 18:35             ` Jeff King
2019-08-01  1:04   ` [git-for-windows] " Bryan Turner
2019-08-01 21:40     ` Johannes Schindelin
2019-08-01 14:12 ` [PATCH] RelNotes/2.23.0: fix a few typos and other minor issues Martin Ågren
2019-08-01 15:56   ` Junio C Hamano
2019-08-01 15:57   ` Junio C Hamano
2019-08-01 19:28     ` Martin Ågren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190731231848.GC1933@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git-for-windows@googlegroups.com \
    --cc=git-packagers@googlegroups.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).