From: Ariadne Conill <ariadne@dereferenced.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, Jonathan Nieder <jrnieder@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git-for-windows@googlegroups.com,
Git Mailing List <git@vger.kernel.org>,
git-packagers@googlegroups.com
Subject: Re: Git for Windows v2.23.0-rc0, was Re: [ANNOUNCE] Git v2.23.0-rc0
Date: Wed, 31 Jul 2019 23:54:07 -0500 [thread overview]
Message-ID: <CAAOiGNzzGqSYxhw=KACYRTxArCY+5H8M4UyY5LFdsnO5VehpOA@mail.gmail.com> (raw)
In-Reply-To: <xmqqsgqlo9j6.fsf@gitster-ct.c.googlers.com>
Hello,
On Wed, Jul 31, 2019 at 10:21 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Jeff King <peff@peff.net> writes:
>
> > This seems OK to me, though I kind of wonder if anybody really wants
> > "auto". Unlike log.decorate, which changes the syntax, there is no real
> > reason to avoid mailmap when somebody else is parsing the output. And I
> > could imagine it is especially confusing if:
> >
> > git log --author=whoever
> >
> > and
> >
> > git log | grep whoever | wc -l
> >
> > do not agree.
>
> I personally do not think it is too late to change for the upcoming
> release, either.
>
> But 'auto' that changes the displayed name depending on the output
> being or not being a terminal makes little sense, I would think, for
> the above reason.
>
I think if the warning is annoying people, then we should just change
the default and document it in the release notes. Ultimately, I think
that this is behaviour that most see as a bug (especially when you
consider that `git shortlog` and `git blame` default to using mailmap
already), so simply describing it as a bugfix is arguably sufficient.
Ariadne
next prev parent reply other threads:[~2019-08-01 4:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 21:49 [ANNOUNCE] Git v2.23.0-rc0 Junio C Hamano
2019-07-31 12:43 ` Git for Windows v2.23.0-rc0, was " Johannes Schindelin
2019-07-31 23:18 ` Jeff King
2019-08-01 0:21 ` Jonathan Nieder
2019-08-01 0:37 ` Ariadne Conill
2019-08-01 1:00 ` Jeff King
2019-08-01 1:14 ` Jonathan Nieder
2019-08-01 1:38 ` Ariadne Conill
2019-08-01 2:53 ` Jeff King
2019-08-01 3:21 ` Junio C Hamano
2019-08-01 4:54 ` Ariadne Conill [this message]
2019-08-01 21:39 ` Johannes Schindelin
2019-08-01 15:45 ` Junio C Hamano
2019-08-01 16:12 ` Ariadne Conill
2019-08-01 21:36 ` Jeff King
2019-08-01 21:46 ` Junio C Hamano
2019-08-01 21:54 ` Junio C Hamano
2019-08-01 22:18 ` Todd Zullinger
2019-08-02 2:27 ` Jonathan Nieder
2019-08-02 16:53 ` Junio C Hamano
2019-08-02 18:35 ` Jeff King
2019-08-01 1:04 ` [git-for-windows] " Bryan Turner
2019-08-01 21:40 ` Johannes Schindelin
2019-08-01 14:12 ` [PATCH] RelNotes/2.23.0: fix a few typos and other minor issues Martin Ågren
2019-08-01 15:56 ` Junio C Hamano
2019-08-01 15:57 ` Junio C Hamano
2019-08-01 19:28 ` Martin Ågren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAOiGNzzGqSYxhw=KACYRTxArCY+5H8M4UyY5LFdsnO5VehpOA@mail.gmail.com' \
--to=ariadne@dereferenced.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git-for-windows@googlegroups.com \
--cc=git-packagers@googlegroups.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).