From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Carlo Arenas <carenas@gmail.com>, Johannes Sixt <j6t@kdbg.org>,
Ramsay Jones <ramsay@ramsayjones.plus.com>,
Thomas Gummerer <t.gummerer@gmail.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] range-diff: fix some 'hdr-check' and sparse warnings
Date: Fri, 02 Oct 2020 10:03:21 -0700 [thread overview]
Message-ID: <xmqq4knca7c6.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1907151647110.47@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Mon, 15 Jul 2019 16:47:32 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> On Sat, 13 Jul 2019, Carlo Arenas wrote:
>
>> On Sat, Jul 13, 2019 at 2:29 PM Junio C Hamano <gitster@pobox.com> wrote:
>> >
>> > I wish if we could say
>> >
>> > struct patch patch = {};
>>
>> that is actually a GNU extension that is supported by gcc and clang (at least)
>> and that sparse also recognizes as valid; it is also valid C++ so it might be
>> even supported by MSVC.
>
> It seems to be supported by MSVC, at least as of VS2019.
In <nycvar.QRO.7.76.6.2010021555290.50@tvgsbejvaqbjf.bet> on Fri, 2
Oct 2020 15:57:45 +0200 (CEST), it was said:
> Before you further split it up, I encourage you to include these patches
> without which the CI builds will continue to fail (Junio, could I ask you
> to either cherry-pick them from https://github.com/git-for-windows/git's
> shears/seen branch, or apply them from the mbox?):
>
> -- snipsnap --
> From e485e006f34922439f2e971a1c5c38b8ca56c011 Mon Sep 17 00:00:00 2001
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
> Date: Wed, 30 Sep 2020 14:46:59 +0200
> Subject: [PATCH 1/3] fixup??? reftable: rest of library
>
> struct abc x = {}
>
> is a GNUism.
Perhaps VS2020 no longer allows it?
;-)
Jokes aside, I think we agreed in that old thread I am responding to
that "= { 0 }" was the way to go, so let's keep doing so.
Thanks.
next prev parent reply other threads:[~2020-10-02 17:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 22:03 [PATCH] range-diff: fix some 'hdr-check' and sparse warnings Ramsay Jones
2019-07-12 5:21 ` Johannes Sixt
2019-07-12 16:44 ` Junio C Hamano
2019-07-13 10:44 ` Johannes Sixt
2019-07-13 12:18 ` Johannes Sixt
2019-07-13 12:56 ` Carlo Arenas
2019-07-13 21:29 ` Junio C Hamano
2019-07-13 22:22 ` Carlo Arenas
2019-07-14 0:51 ` Jeff King
2019-07-14 8:30 ` Johannes Sixt
2019-07-15 14:46 ` Jeff King
2019-07-15 17:30 ` Johannes Sixt
2019-07-15 18:15 ` Jeff King
2019-07-16 19:01 ` Junio C Hamano
2019-07-16 20:01 ` Jeff King
2019-07-17 18:13 ` Junio C Hamano
2019-07-17 19:21 ` Jeff King
2019-07-17 20:10 ` Junio C Hamano
2019-07-17 17:23 ` Johannes Sixt
2019-07-15 14:47 ` Johannes Schindelin
2020-10-02 17:03 ` Junio C Hamano [this message]
2020-10-04 18:35 ` Johannes Schindelin
2019-07-14 8:15 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4knca7c6.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=ramsay@ramsayjones.plus.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).