From: Johannes Sixt <j6t@kdbg.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, Carlo Arenas <carenas@gmail.com>,
Ramsay Jones <ramsay@ramsayjones.plus.com>,
Thomas Gummerer <t.gummerer@gmail.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] range-diff: fix some 'hdr-check' and sparse warnings
Date: Wed, 17 Jul 2019 19:23:16 +0200 [thread overview]
Message-ID: <a6af2961-3f09-5d8a-b92b-c50e6877ec81@kdbg.org> (raw)
In-Reply-To: <xmqqo91t3itl.fsf@gitster-ct.c.googlers.com>
Am 16.07.19 um 21:01 schrieb Junio C Hamano:
> but as long as we declare that we take "{ 0 }" as a mere convention
> [...], I am perfectly fine with it, and if it is hidden
> behind a macro, that would be even better ;-)
And I thought that "Avoid macros!" would be a welcome guideline...
I think we enter subjective territory. Let's stop here.
-- Hannes
next prev parent reply other threads:[~2019-07-17 17:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 22:03 [PATCH] range-diff: fix some 'hdr-check' and sparse warnings Ramsay Jones
2019-07-12 5:21 ` Johannes Sixt
2019-07-12 16:44 ` Junio C Hamano
2019-07-13 10:44 ` Johannes Sixt
2019-07-13 12:18 ` Johannes Sixt
2019-07-13 12:56 ` Carlo Arenas
2019-07-13 21:29 ` Junio C Hamano
2019-07-13 22:22 ` Carlo Arenas
2019-07-14 0:51 ` Jeff King
2019-07-14 8:30 ` Johannes Sixt
2019-07-15 14:46 ` Jeff King
2019-07-15 17:30 ` Johannes Sixt
2019-07-15 18:15 ` Jeff King
2019-07-16 19:01 ` Junio C Hamano
2019-07-16 20:01 ` Jeff King
2019-07-17 18:13 ` Junio C Hamano
2019-07-17 19:21 ` Jeff King
2019-07-17 20:10 ` Junio C Hamano
2019-07-17 17:23 ` Johannes Sixt [this message]
2019-07-15 14:47 ` Johannes Schindelin
2020-10-02 17:03 ` Junio C Hamano
2020-10-04 18:35 ` Johannes Schindelin
2019-07-14 8:15 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6af2961-3f09-5d8a-b92b-c50e6877ec81@kdbg.org \
--to=j6t@kdbg.org \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=ramsay@ramsayjones.plus.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).