From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Johannes Sixt <j6t@kdbg.org>, Carlo Arenas <carenas@gmail.com>,
Ramsay Jones <ramsay@ramsayjones.plus.com>,
Thomas Gummerer <t.gummerer@gmail.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] range-diff: fix some 'hdr-check' and sparse warnings
Date: Wed, 17 Jul 2019 13:10:35 -0700 [thread overview]
Message-ID: <xmqqmuhczakk.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190717192121.GA5447@sigill.intra.peff.net> (Jeff King's message of "Wed, 17 Jul 2019 15:21:21 -0400")
Jeff King <peff@peff.net> writes:
> Other than that, our options seem to be:
>
> 1. Live with it. IIRC we're already not sparse-clean, and Ramsay
> mostly looks at the diff to find new problems.
OK.
> 2. Pass -Wno-non-pointer-null to sparse. Unfortunately that also
> disables more useful warnings (like passing "0" instead of NULL to
> a function).
Non starter, I am afraind. The loss outweighs.
> 3. Switch to NULL here, and adhere to that going forward.
This does not sound too bad.
next prev parent reply other threads:[~2019-07-17 20:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 22:03 [PATCH] range-diff: fix some 'hdr-check' and sparse warnings Ramsay Jones
2019-07-12 5:21 ` Johannes Sixt
2019-07-12 16:44 ` Junio C Hamano
2019-07-13 10:44 ` Johannes Sixt
2019-07-13 12:18 ` Johannes Sixt
2019-07-13 12:56 ` Carlo Arenas
2019-07-13 21:29 ` Junio C Hamano
2019-07-13 22:22 ` Carlo Arenas
2019-07-14 0:51 ` Jeff King
2019-07-14 8:30 ` Johannes Sixt
2019-07-15 14:46 ` Jeff King
2019-07-15 17:30 ` Johannes Sixt
2019-07-15 18:15 ` Jeff King
2019-07-16 19:01 ` Junio C Hamano
2019-07-16 20:01 ` Jeff King
2019-07-17 18:13 ` Junio C Hamano
2019-07-17 19:21 ` Jeff King
2019-07-17 20:10 ` Junio C Hamano [this message]
2019-07-17 17:23 ` Johannes Sixt
2019-07-15 14:47 ` Johannes Schindelin
2020-10-02 17:03 ` Junio C Hamano
2020-10-04 18:35 ` Johannes Schindelin
2019-07-14 8:15 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmuhczakk.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=peff@peff.net \
--cc=ramsay@ramsayjones.plus.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).