* [PATCH] pathspec.c: Fix some sparse warnings
@ 2012-09-25 17:15 Ramsay Jones
2012-09-25 18:03 ` Adam Spiers
0 siblings, 1 reply; 5+ messages in thread
From: Ramsay Jones @ 2012-09-25 17:15 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, GIT Mailing-list
Sparse issues a warning for all six external symbols defined in this
file. In order to suppress the warnings, we include the 'pathspec.h'
header file, which contains the relevant extern declarations for these
symbols.
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Hi Adam,
When you re-roll your 'as/check-ignore' branch could you please squash
this patch into commit a1080211 ("pathspec.c: move reusable code from
builtin/add.c", 20-09-2012).
Thanks!
ATB,
Ramsay Jones
pathspec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/pathspec.c b/pathspec.c
index 9525c7c..5dba000 100644
--- a/pathspec.c
+++ b/pathspec.c
@@ -1,5 +1,6 @@
#include "cache.h"
#include "dir.h"
+#include "pathspec.h"
void validate_path(const char *prefix, const char *path)
{
--
1.7.12
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] pathspec.c: Fix some sparse warnings
2012-09-25 17:15 [PATCH] pathspec.c: Fix some sparse warnings Ramsay Jones
@ 2012-09-25 18:03 ` Adam Spiers
0 siblings, 0 replies; 5+ messages in thread
From: Adam Spiers @ 2012-09-25 18:03 UTC (permalink / raw)
To: Ramsay Jones; +Cc: Junio C Hamano, GIT Mailing-list
On Tue, Sep 25, 2012 at 6:15 PM, Ramsay Jones
<ramsay@ramsay1.demon.co.uk> wrote:
>
> Sparse issues a warning for all six external symbols defined in this
> file. In order to suppress the warnings, we include the 'pathspec.h'
> header file, which contains the relevant extern declarations for these
> symbols.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
>
> Hi Adam,
>
> When you re-roll your 'as/check-ignore' branch could you please squash
> this patch into commit a1080211 ("pathspec.c: move reusable code from
> builtin/add.c", 20-09-2012).
Will do, thanks a lot!
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] pathspec.c: Fix some sparse warnings
@ 2012-10-28 21:09 Ramsay Jones
2012-10-28 23:31 ` Adam Spiers
2012-10-29 5:55 ` Jeff King
0 siblings, 2 replies; 5+ messages in thread
From: Ramsay Jones @ 2012-10-28 21:09 UTC (permalink / raw)
To: Nguyen Thai Ngoc Duy; +Cc: git, Jeff King, GIT Mailing-list
Sparse issues a warning for all six external symbols defined in this
file. In order to suppress the warnings, we include the 'pathspec.h'
header file, which contains the relevant extern declarations for these
symbols.
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Hi Nguyen,
I asked Adam to squash this patch into his 'as/check-ignore' branch
when he next re-rolled the branch. However, it appears that you
resubmitted that branch instead ... :-D
I don't know if this branch is ready to progress to next yet, but
could somebody (yourself, Adam or Jeff?) please squash this into
commit 1a88ae42 ("pathspec.c: move reusable code from builtin/add.c")
before it hits next.
Thanks!
ATB,
Ramsay Jones
pathspec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/pathspec.c b/pathspec.c
index a9c5b5b..efdabe4 100644
--- a/pathspec.c
+++ b/pathspec.c
@@ -1,5 +1,6 @@
#include "cache.h"
#include "dir.h"
+#include "pathspec.h"
void validate_path(const char *prefix, const char *path)
{
--
1.8.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] pathspec.c: Fix some sparse warnings
2012-10-28 21:09 Ramsay Jones
@ 2012-10-28 23:31 ` Adam Spiers
2012-10-29 5:55 ` Jeff King
1 sibling, 0 replies; 5+ messages in thread
From: Adam Spiers @ 2012-10-28 23:31 UTC (permalink / raw)
To: Ramsay Jones; +Cc: Nguyen Thai Ngoc Duy, Jeff King, GIT Mailing-list
On Sun, Oct 28, 2012 at 9:09 PM, Ramsay Jones
<ramsay@ramsay1.demon.co.uk> wrote:
> Sparse issues a warning for all six external symbols defined in this
> file. In order to suppress the warnings, we include the 'pathspec.h'
> header file, which contains the relevant extern declarations for these
> symbols.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
>
> Hi Nguyen,
>
> I asked Adam to squash this patch into his 'as/check-ignore' branch
> when he next re-rolled the branch. However, it appears that you
> resubmitted that branch instead ... :-D
>
> I don't know if this branch is ready to progress to next yet, but
> could somebody (yourself, Adam or Jeff?) please squash this into
> commit 1a88ae42 ("pathspec.c: move reusable code from builtin/add.c")
> before it hits next.
Noted - thanks a lot Ramsay. My diary is a bit gentler this week so
I'm hoping to get some attention back on these patch series.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pathspec.c: Fix some sparse warnings
2012-10-28 21:09 Ramsay Jones
2012-10-28 23:31 ` Adam Spiers
@ 2012-10-29 5:55 ` Jeff King
1 sibling, 0 replies; 5+ messages in thread
From: Jeff King @ 2012-10-29 5:55 UTC (permalink / raw)
To: Ramsay Jones; +Cc: Nguyen Thai Ngoc Duy, git, GIT Mailing-list
On Sun, Oct 28, 2012 at 09:09:19PM +0000, Ramsay Jones wrote:
> I asked Adam to squash this patch into his 'as/check-ignore' branch
> when he next re-rolled the branch. However, it appears that you
> resubmitted that branch instead ... :-D
>
> I don't know if this branch is ready to progress to next yet, but
> could somebody (yourself, Adam or Jeff?) please squash this into
> commit 1a88ae42 ("pathspec.c: move reusable code from builtin/add.c")
> before it hits next.
I squashed it into my version of as/check-ignore, but if we are
expecting a re-roll, please everybody remember to include it.
-Peff
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-10-29 5:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-25 17:15 [PATCH] pathspec.c: Fix some sparse warnings Ramsay Jones
2012-09-25 18:03 ` Adam Spiers
-- strict thread matches above, loose matches on Subject: below --
2012-10-28 21:09 Ramsay Jones
2012-10-28 23:31 ` Adam Spiers
2012-10-29 5:55 ` Jeff King
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).