From: Adam Spiers <git@adamspiers.org>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
Jeff King <peff@peff.net>, GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] pathspec.c: Fix some sparse warnings
Date: Sun, 28 Oct 2012 23:31:35 +0000 [thread overview]
Message-ID: <CAOkDyE8BF2u0zqpZb9eQQ_hsNWzYhf1=DteAFK3QXmAONjGVbQ@mail.gmail.com> (raw)
In-Reply-To: <508D9EFF.3040900@ramsay1.demon.co.uk>
On Sun, Oct 28, 2012 at 9:09 PM, Ramsay Jones
<ramsay@ramsay1.demon.co.uk> wrote:
> Sparse issues a warning for all six external symbols defined in this
> file. In order to suppress the warnings, we include the 'pathspec.h'
> header file, which contains the relevant extern declarations for these
> symbols.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
>
> Hi Nguyen,
>
> I asked Adam to squash this patch into his 'as/check-ignore' branch
> when he next re-rolled the branch. However, it appears that you
> resubmitted that branch instead ... :-D
>
> I don't know if this branch is ready to progress to next yet, but
> could somebody (yourself, Adam or Jeff?) please squash this into
> commit 1a88ae42 ("pathspec.c: move reusable code from builtin/add.c")
> before it hits next.
Noted - thanks a lot Ramsay. My diary is a bit gentler this week so
I'm hoping to get some attention back on these patch series.
next prev parent reply other threads:[~2012-10-28 23:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-28 21:09 [PATCH] pathspec.c: Fix some sparse warnings Ramsay Jones
2012-10-28 23:31 ` Adam Spiers [this message]
2012-10-29 5:55 ` Jeff King
-- strict thread matches above, loose matches on Subject: below --
2012-09-25 17:15 Ramsay Jones
2012-09-25 18:03 ` Adam Spiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOkDyE8BF2u0zqpZb9eQQ_hsNWzYhf1=DteAFK3QXmAONjGVbQ@mail.gmail.com' \
--to=git@adamspiers.org \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).