From: Adam Spiers <git@adamspiers.org>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] pathspec.c: Fix some sparse warnings
Date: Tue, 25 Sep 2012 19:03:06 +0100 [thread overview]
Message-ID: <CAOkDyE8NGbApsF+v=UJUuaxvd9PYUfvf4yNDhNpHZ0tuqHHoBg@mail.gmail.com> (raw)
In-Reply-To: <5061E6BD.2070109@ramsay1.demon.co.uk>
On Tue, Sep 25, 2012 at 6:15 PM, Ramsay Jones
<ramsay@ramsay1.demon.co.uk> wrote:
>
> Sparse issues a warning for all six external symbols defined in this
> file. In order to suppress the warnings, we include the 'pathspec.h'
> header file, which contains the relevant extern declarations for these
> symbols.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
>
> Hi Adam,
>
> When you re-roll your 'as/check-ignore' branch could you please squash
> this patch into commit a1080211 ("pathspec.c: move reusable code from
> builtin/add.c", 20-09-2012).
Will do, thanks a lot!
next prev parent reply other threads:[~2012-09-25 18:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 17:15 [PATCH] pathspec.c: Fix some sparse warnings Ramsay Jones
2012-09-25 18:03 ` Adam Spiers [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-10-28 21:09 Ramsay Jones
2012-10-28 23:31 ` Adam Spiers
2012-10-29 5:55 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOkDyE8NGbApsF+v=UJUuaxvd9PYUfvf4yNDhNpHZ0tuqHHoBg@mail.gmail.com' \
--to=git@adamspiers.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).