From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/3] completion: remove old code
Date: Mon, 30 Jan 2012 12:51:04 +0200 [thread overview]
Message-ID: <CAMP44s2j+qotu8Fb-1qq9bqHqt+ZF877YzZFXHiMo7Z_BGzTMA@mail.gmail.com> (raw)
In-Reply-To: <7vd3a1erwf.fsf@alter.siamese.dyndns.org>
On Mon, Jan 30, 2012 at 6:27 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> OK, maybe some people use it, but most likely they are using an old
>> version of git, and thus an old version of the completion script.
>
> Please adjust your attitude about backward compatibility to match the
> standard used for other parts of Git.
What attitude? I am simply stating a fact. How much percentage of
people do you think still have .git/remotes around? How many people do
you think have clones more than 3 years old? And how many of these
people would complain if remotes were not properly completed for these
repos?
I doubt anybody would have complained, but I guess we would never
know, because I already proposed a solution that would work for them
and only uses a *single* line of code, unlike the current 40 ones.
I don't see what is the problem with the attitude of sending a patch
to remove code that most likely nobody cares about (neither you or I
have numbers on this), and then finding an alternative when people do
care about it.
Cheers.
--
Felipe Contreras
next prev parent reply other threads:[~2012-01-30 10:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-29 23:41 [PATCH 0/3] completion: trivial cleanups Felipe Contreras
2012-01-29 23:41 ` [PATCH 1/3] completion: be nicer with zsh Felipe Contreras
2012-01-30 4:34 ` Junio C Hamano
2012-01-30 5:50 ` Junio C Hamano
2012-01-30 10:30 ` Felipe Contreras
2012-01-30 10:35 ` Felipe Contreras
2012-01-30 18:07 ` Junio C Hamano
2012-01-30 18:21 ` Felipe Contreras
2012-01-29 23:41 ` [PATCH 2/3] completion: remove old code Felipe Contreras
2012-01-30 2:36 ` Jonathan Nieder
2012-01-30 3:24 ` Felipe Contreras
2012-01-30 3:27 ` Jonathan Nieder
2012-01-30 4:27 ` Junio C Hamano
2012-01-30 10:51 ` Felipe Contreras [this message]
2012-01-30 11:19 ` Frans Klaver
2012-01-30 11:55 ` Felipe Contreras
2012-01-30 12:21 ` Frans Klaver
2012-01-30 13:59 ` Felipe Contreras
2012-01-30 14:02 ` Jonathan Nieder
2012-01-29 23:41 ` [PATCH 3/3] completion: remove unused code Felipe Contreras
2012-01-30 2:50 ` Jonathan Nieder
2012-01-30 3:29 ` Jonathan Nieder
2012-01-30 3:30 ` Felipe Contreras
2012-01-30 7:44 ` Thomas Rast
2012-01-30 8:22 ` Junio C Hamano
2012-01-30 10:38 ` Felipe Contreras
2012-01-30 13:19 ` Thomas Rast
2012-01-30 13:51 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s2j+qotu8Fb-1qq9bqHqt+ZF877YzZFXHiMo7Z_BGzTMA@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).