git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/3] completion: remove unused code
Date: Sun, 29 Jan 2012 21:29:13 -0600	[thread overview]
Message-ID: <20120130032913.GC10618@burratino> (raw)
In-Reply-To: <20120130025014.GA15944@burratino>

Jonathan Nieder wrote:

> What codebase does this apply to?  My copy of git-completion.bash
> contains a number of calls to __git_shopt

Ah, now I get it.  This would have been easier to understand if
squashed in with patch 2/3.

And it certainly looks like a good change, yes. :)

Thanks for explaining,
Jonathan

  reply	other threads:[~2012-01-30  3:29 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-29 23:41 [PATCH 0/3] completion: trivial cleanups Felipe Contreras
2012-01-29 23:41 ` [PATCH 1/3] completion: be nicer with zsh Felipe Contreras
2012-01-30  4:34   ` Junio C Hamano
2012-01-30  5:50     ` Junio C Hamano
2012-01-30 10:30       ` Felipe Contreras
2012-01-30 10:35     ` Felipe Contreras
2012-01-30 18:07       ` Junio C Hamano
2012-01-30 18:21         ` Felipe Contreras
2012-01-29 23:41 ` [PATCH 2/3] completion: remove old code Felipe Contreras
2012-01-30  2:36   ` Jonathan Nieder
2012-01-30  3:24     ` Felipe Contreras
2012-01-30  3:27       ` Jonathan Nieder
2012-01-30  4:27       ` Junio C Hamano
2012-01-30 10:51         ` Felipe Contreras
2012-01-30 11:19           ` Frans Klaver
2012-01-30 11:55             ` Felipe Contreras
2012-01-30 12:21               ` Frans Klaver
2012-01-30 13:59                 ` Felipe Contreras
2012-01-30 14:02                   ` Jonathan Nieder
2012-01-29 23:41 ` [PATCH 3/3] completion: remove unused code Felipe Contreras
2012-01-30  2:50   ` Jonathan Nieder
2012-01-30  3:29     ` Jonathan Nieder [this message]
2012-01-30  3:30     ` Felipe Contreras
2012-01-30  7:44       ` Thomas Rast
2012-01-30  8:22         ` Junio C Hamano
2012-01-30 10:38           ` Felipe Contreras
2012-01-30 13:19             ` Thomas Rast
2012-01-30 13:51               ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120130032913.GC10618@burratino \
    --to=jrnieder@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).