From: Felipe Contreras <felipe.contreras@gmail.com>
To: git@vger.kernel.org
Cc: Felipe Contreras <felipe.contreras@gmail.com>
Subject: [PATCH 2/3] completion: remove old code
Date: Mon, 30 Jan 2012 01:41:18 +0200 [thread overview]
Message-ID: <1327880479-25275-3-git-send-email-felipe.contreras@gmail.com> (raw)
In-Reply-To: <1327880479-25275-1-git-send-email-felipe.contreras@gmail.com>
We don't need to check for GIT_DIR/remotes, right? This was removed long
time ago.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
contrib/completion/git-completion.bash | 8 +-------
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 7051c7a..f7278b5 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -643,13 +643,7 @@ __git_refs_remotes ()
__git_remotes ()
{
- local i ngoff IFS=$'\n' d="$(__gitdir)"
- __git_shopt -q nullglob || ngoff=1
- __git_shopt -s nullglob
- for i in "$d/remotes"/*; do
- echo ${i#$d/remotes/}
- done
- [ "$ngoff" ] && __git_shopt -u nullglob
+ local i IFS=$'\n' d="$(__gitdir)"
for i in $(git --git-dir="$d" config --get-regexp 'remote\..*\.url' 2>/dev/null); do
i="${i#remote.}"
echo "${i/.url*/}"
--
1.7.8.3
next prev parent reply other threads:[~2012-01-29 23:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-29 23:41 [PATCH 0/3] completion: trivial cleanups Felipe Contreras
2012-01-29 23:41 ` [PATCH 1/3] completion: be nicer with zsh Felipe Contreras
2012-01-30 4:34 ` Junio C Hamano
2012-01-30 5:50 ` Junio C Hamano
2012-01-30 10:30 ` Felipe Contreras
2012-01-30 10:35 ` Felipe Contreras
2012-01-30 18:07 ` Junio C Hamano
2012-01-30 18:21 ` Felipe Contreras
2012-01-29 23:41 ` Felipe Contreras [this message]
2012-01-30 2:36 ` [PATCH 2/3] completion: remove old code Jonathan Nieder
2012-01-30 3:24 ` Felipe Contreras
2012-01-30 3:27 ` Jonathan Nieder
2012-01-30 4:27 ` Junio C Hamano
2012-01-30 10:51 ` Felipe Contreras
2012-01-30 11:19 ` Frans Klaver
2012-01-30 11:55 ` Felipe Contreras
2012-01-30 12:21 ` Frans Klaver
2012-01-30 13:59 ` Felipe Contreras
2012-01-30 14:02 ` Jonathan Nieder
2012-01-29 23:41 ` [PATCH 3/3] completion: remove unused code Felipe Contreras
2012-01-30 2:50 ` Jonathan Nieder
2012-01-30 3:29 ` Jonathan Nieder
2012-01-30 3:30 ` Felipe Contreras
2012-01-30 7:44 ` Thomas Rast
2012-01-30 8:22 ` Junio C Hamano
2012-01-30 10:38 ` Felipe Contreras
2012-01-30 13:19 ` Thomas Rast
2012-01-30 13:51 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327880479-25275-3-git-send-email-felipe.contreras@gmail.com \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).