From: Felipe Contreras <felipe.contreras@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/3] completion: remove unused code
Date: Mon, 30 Jan 2012 05:30:49 +0200 [thread overview]
Message-ID: <CAMP44s1bZeednbHfqXANZR5zVVvGwjRpuV5TFmnh212FD7E-Vg@mail.gmail.com> (raw)
In-Reply-To: <20120130025014.GA15944@burratino>
On Mon, Jan 30, 2012 at 4:50 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Felipe Contreras wrote:
>
>> No need for thus rather complicated piece of code :)
> [...]
>> contrib/completion/git-completion.bash | 30 ------------------------------
>> 1 files changed, 0 insertions(+), 30 deletions(-)
> [...]
>> --- a/contrib/completion/git-completion.bash
>> +++ b/contrib/completion/git-completion.bash
>> @@ -2730,33 +2730,3 @@ if [ Cygwin = "$(uname -o 2>/dev/null)" ]; then
> [...]
>> -if [[ -n ${ZSH_VERSION-} ]]; then
>> - __git_shopt () {
> [...]
>> -else
>> - __git_shopt () {
>> - shopt "$@"
>> - }
>> -fi
>
> What codebase does this apply to? My copy of git-completion.bash
> contains a number of calls to __git_shopt, which will fail after this
> change.
The latest and greatest of course:
http://git.kernel.org/?p=git/git.git;a=blob;f=contrib/completion/git-completion.bash
It's only used in __git_remotes.
> By the way, is there any reason you did not cc this series to Gábor or
> others who also know the completion code well? The patches are not
> marked with RFC/ so I assume they are intended for direct application,
> which seems somewhat odd to me.
No reason. I hope they read the mailing list, otherwise I'll resend
and CC them. A get_maintainers script, or something like that would
make things easier.
Cheers.
--
Felipe Contreras
next prev parent reply other threads:[~2012-01-30 3:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-29 23:41 [PATCH 0/3] completion: trivial cleanups Felipe Contreras
2012-01-29 23:41 ` [PATCH 1/3] completion: be nicer with zsh Felipe Contreras
2012-01-30 4:34 ` Junio C Hamano
2012-01-30 5:50 ` Junio C Hamano
2012-01-30 10:30 ` Felipe Contreras
2012-01-30 10:35 ` Felipe Contreras
2012-01-30 18:07 ` Junio C Hamano
2012-01-30 18:21 ` Felipe Contreras
2012-01-29 23:41 ` [PATCH 2/3] completion: remove old code Felipe Contreras
2012-01-30 2:36 ` Jonathan Nieder
2012-01-30 3:24 ` Felipe Contreras
2012-01-30 3:27 ` Jonathan Nieder
2012-01-30 4:27 ` Junio C Hamano
2012-01-30 10:51 ` Felipe Contreras
2012-01-30 11:19 ` Frans Klaver
2012-01-30 11:55 ` Felipe Contreras
2012-01-30 12:21 ` Frans Klaver
2012-01-30 13:59 ` Felipe Contreras
2012-01-30 14:02 ` Jonathan Nieder
2012-01-29 23:41 ` [PATCH 3/3] completion: remove unused code Felipe Contreras
2012-01-30 2:50 ` Jonathan Nieder
2012-01-30 3:29 ` Jonathan Nieder
2012-01-30 3:30 ` Felipe Contreras [this message]
2012-01-30 7:44 ` Thomas Rast
2012-01-30 8:22 ` Junio C Hamano
2012-01-30 10:38 ` Felipe Contreras
2012-01-30 13:19 ` Thomas Rast
2012-01-30 13:51 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s1bZeednbHfqXANZR5zVVvGwjRpuV5TFmnh212FD7E-Vg@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).