From: Thomas Rast <trast@inf.ethz.ch>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Junio C Hamano <jch2355@gmail.com>,
Jonathan Nieder <jrnieder@gmail.com>, <git@vger.kernel.org>
Subject: Re: [PATCH 3/3] completion: remove unused code
Date: Mon, 30 Jan 2012 14:19:29 +0100 [thread overview]
Message-ID: <87pqe1nx9a.fsf@thomas.inf.ethz.ch> (raw)
In-Reply-To: <CAMP44s2ooo1uArhhtJkX3S9N=iE4MNJivMSvr3hsOkxFmJupFA@mail.gmail.com> (Felipe Contreras's message of "Mon, 30 Jan 2012 12:38:35 +0200")
Felipe Contreras <felipe.contreras@gmail.com> writes:
> On Mon, Jan 30, 2012 at 10:22 AM, Junio C Hamano <jch2355@gmail.com> wrote:
>> Thomas Rast <trast@inf.ethz.ch> wrote:
>>>Felipe Contreras <felipe.contreras@gmail.com> writes:
>>>
>>>> No reason. I hope they read the mailing list, otherwise I'll resend
>>>> and CC them. A get_maintainers script, or something like that would
>>>> make things easier.
>>>
>>>I simply use
>>>
>>> git shortlog -sn --no-merges v1.7.0.. -- contrib/completion/
>>>
>>>(In many parts the revision limiter can be omitted without losing much,
>>>but e.g. here this drops Shawn who hasn't worked on it since 2009.)
>>
>> Or "--since=1.year", which you can keep using forever without adjusting.
>
> Perhaps something like that can be stored in a script somewhere in
> git's codebase so that people can set sendemail.cccmd to that.
Umm, that seems rather AI-complete. You should always compile the list
by hand.
For example, the list in this case started
25 SZEDER Gábor
4 Michael J Gruber
3 Teemu Matilainen
3 Thomas Rast
Would you Cc Michael, Teemu and me? Probably not. What if it started
5 SZEDER Gábor
4 Michael J Gruber
3 Teemu Matilainen
3 Thomas Rast
Also, something I didn't mention so far was that you may be patching
squarely into the code of one contributor, even if he only had a single
patch in that area. To catch this, you should blame the code you are
fixing (you already checked the message of the commit to verify whether
the bug/feature was intentional, right?). On top of that, the patch may
have involved a large number of people not listed in the Author field.
As a random example,
$ git shortlog -sn --no-merges v1.7.0..origin/next -- grep.[ch] builtin/grep.[ch]
15 René Scharfe
9 Junio C Hamano
8 Nguyễn Thái Ngọc Duy
5 Michał Kiedrowicz
4 Johannes Schindelin
3 Jeff King
3 Thomas Rast
but if you were to submit a patch that disputes the case made by
53b8d931, you should probably cc René, Peff and me (see the Helped-by
lines).
Ok, this got rather long-winded. But I think the bottom line is, trying
to put this in sendemail.cccmd is trying to script common sense.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2012-01-30 13:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-29 23:41 [PATCH 0/3] completion: trivial cleanups Felipe Contreras
2012-01-29 23:41 ` [PATCH 1/3] completion: be nicer with zsh Felipe Contreras
2012-01-30 4:34 ` Junio C Hamano
2012-01-30 5:50 ` Junio C Hamano
2012-01-30 10:30 ` Felipe Contreras
2012-01-30 10:35 ` Felipe Contreras
2012-01-30 18:07 ` Junio C Hamano
2012-01-30 18:21 ` Felipe Contreras
2012-01-29 23:41 ` [PATCH 2/3] completion: remove old code Felipe Contreras
2012-01-30 2:36 ` Jonathan Nieder
2012-01-30 3:24 ` Felipe Contreras
2012-01-30 3:27 ` Jonathan Nieder
2012-01-30 4:27 ` Junio C Hamano
2012-01-30 10:51 ` Felipe Contreras
2012-01-30 11:19 ` Frans Klaver
2012-01-30 11:55 ` Felipe Contreras
2012-01-30 12:21 ` Frans Klaver
2012-01-30 13:59 ` Felipe Contreras
2012-01-30 14:02 ` Jonathan Nieder
2012-01-29 23:41 ` [PATCH 3/3] completion: remove unused code Felipe Contreras
2012-01-30 2:50 ` Jonathan Nieder
2012-01-30 3:29 ` Jonathan Nieder
2012-01-30 3:30 ` Felipe Contreras
2012-01-30 7:44 ` Thomas Rast
2012-01-30 8:22 ` Junio C Hamano
2012-01-30 10:38 ` Felipe Contreras
2012-01-30 13:19 ` Thomas Rast [this message]
2012-01-30 13:51 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqe1nx9a.fsf@thomas.inf.ethz.ch \
--to=trast@inf.ethz.ch \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=jch2355@gmail.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).