From: Jeff King <peff@peff.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Johannes Postler <johannes.postler@txture.io>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH 1/3] format-patch: refactor output selection
Date: Wed, 4 Nov 2020 12:13:44 -0500 [thread overview]
Message-ID: <20201104171344.GA3047090@coredump.intra.peff.net> (raw)
In-Reply-To: <CAPig+cRG4uPL1TDpEOgOZwSEJfyt-d0XmsVz3hcCebgwbO_v_A@mail.gmail.com>
On Wed, Nov 04, 2020 at 12:01:53PM -0500, Eric Sunshine wrote:
> > diff --git a/builtin/log.c b/builtin/log.c
> > @@ -1942,20 +1942,20 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
> > + if (use_stdout + !!output_directory > 1)
> > + die(_("specify only one of --stdout, --output, and --output-directory"));
>
> Is mention of --output intentional here? The commit message only talks
> about --stdout and --output-directory.
Whoops, thanks. I wrote this line after adding the new feature, but
forgot to revise it when I rebased.
> It's subjective, but "mutually exclusive" sounds a bit more consistent
> with other similar error messages elsewhere:
>
> --stdout, --output, and --output-directory are mutually exclusive
Yeah, that reads better. I remember I reworded it a few times to try to
get it not-awkward, but I'm not sure how I failed to come up with that
quite obvious wording. ;)
-Peff
next prev parent reply other threads:[~2020-11-04 17:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 10:18 [Bug report] Crash when creating patch Johannes Postler
2020-11-04 13:24 ` Jeff King
2020-11-04 13:25 ` [PATCH 1/3] format-patch: refactor output selection Jeff King
2020-11-04 17:01 ` Eric Sunshine
2020-11-04 17:13 ` Jeff King [this message]
2020-11-04 13:27 ` [PATCH 2/3] format-patch: tie file-opening logic to output_directory Jeff King
2020-11-04 17:03 ` Eric Sunshine
2020-11-04 13:29 ` [PATCH 3/3] format-patch: support --output option Jeff King
2020-11-04 17:27 ` Eric Sunshine
2020-11-04 19:15 ` Jeff King
2020-11-04 20:16 ` Eric Sunshine
2020-11-04 18:00 ` Junio C Hamano
2020-11-04 19:26 ` [PATCH v2] format-patch --output Jeff King
2020-11-04 19:28 ` [PATCH v2 1/3] format-patch: refactor output selection Jeff King
2020-11-04 19:28 ` [PATCH v2 2/3] format-patch: tie file-opening logic to output_directory Jeff King
2020-11-04 19:28 ` [PATCH v2 3/3] format-patch: support --output option Jeff King
2020-11-05 6:30 ` [PATCH v2] format-patch --output Johannes Postler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104171344.GA3047090@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=johannes.postler@txture.io \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).