From: Jeff King <peff@peff.net>
To: Johannes Postler <johannes.postler@txture.io>
Cc: git@vger.kernel.org
Subject: [PATCH 1/3] format-patch: refactor output selection
Date: Wed, 4 Nov 2020 08:25:22 -0500 [thread overview]
Message-ID: <20201104132522.GA3030146@coredump.intra.peff.net> (raw)
In-Reply-To: <20201104132428.GA2491189@coredump.intra.peff.net>
The --stdout and --output-directory options are mutually exclusive, but
it's hard to tell from reading the code. We have three separate
conditionals that check for use_stdout, and it's only after we've set up
the output_directory fully that we check whether the user also specified
--stdout.
Instead, let's check the exclusion explicitly first, then have a single
conditional that handles stdout versus an output directory. This is
slightly easier to follow now, and also will keep things sane when we
add another output mode in a future patch.
Signed-off-by: Jeff King <peff@peff.net>
---
builtin/log.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/builtin/log.c b/builtin/log.c
index 9f939e6cdf..4c391ba3ca 100644
--- a/builtin/log.c
+++ b/builtin/log.c
@@ -1942,20 +1942,20 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
if (rev.show_notes)
load_display_notes(&rev.notes_opt);
- if (!output_directory && !use_stdout)
- output_directory = config_output_directory;
+ if (use_stdout + !!output_directory > 1)
+ die(_("specify only one of --stdout, --output, and --output-directory"));
- if (!use_stdout)
- output_directory = set_outdir(prefix, output_directory);
- else
+ if (use_stdout) {
setup_pager();
-
- if (output_directory) {
+ } else {
int saved;
+
+ if (!output_directory)
+ output_directory = config_output_directory;
+ output_directory = set_outdir(prefix, output_directory);
+
if (rev.diffopt.use_color != GIT_COLOR_ALWAYS)
rev.diffopt.use_color = GIT_COLOR_NEVER;
- if (use_stdout)
- die(_("standard output, or directory, which one?"));
/*
* We consider <outdir> as 'outside of gitdir', therefore avoid
* applying adjust_shared_perm in s-c-l-d.
--
2.29.2.559.g8ec94df761
next prev parent reply other threads:[~2020-11-04 13:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 10:18 [Bug report] Crash when creating patch Johannes Postler
2020-11-04 13:24 ` Jeff King
2020-11-04 13:25 ` Jeff King [this message]
2020-11-04 17:01 ` [PATCH 1/3] format-patch: refactor output selection Eric Sunshine
2020-11-04 17:13 ` Jeff King
2020-11-04 13:27 ` [PATCH 2/3] format-patch: tie file-opening logic to output_directory Jeff King
2020-11-04 17:03 ` Eric Sunshine
2020-11-04 13:29 ` [PATCH 3/3] format-patch: support --output option Jeff King
2020-11-04 17:27 ` Eric Sunshine
2020-11-04 19:15 ` Jeff King
2020-11-04 20:16 ` Eric Sunshine
2020-11-04 18:00 ` Junio C Hamano
2020-11-04 19:26 ` [PATCH v2] format-patch --output Jeff King
2020-11-04 19:28 ` [PATCH v2 1/3] format-patch: refactor output selection Jeff King
2020-11-04 19:28 ` [PATCH v2 2/3] format-patch: tie file-opening logic to output_directory Jeff King
2020-11-04 19:28 ` [PATCH v2 3/3] format-patch: support --output option Jeff King
2020-11-05 6:30 ` [PATCH v2] format-patch --output Johannes Postler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104132522.GA3030146@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=johannes.postler@txture.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).