From: Eric Sunshine <firstname.lastname@example.org> To: Jeff King <email@example.com> Cc: Johannes Postler <firstname.lastname@example.org>, Git List <email@example.com> Subject: Re: [PATCH 3/3] format-patch: support --output option Date: Wed, 4 Nov 2020 15:16:04 -0500 [thread overview] Message-ID: <CAPig+cSOB+raZHEpSeqnZZ-VHNqLqVyrfVUA8fCr97mv8oSBFw@mail.gmail.com> (raw) In-Reply-To: <20201104191559.GA3053889@coredump.intra.peff.net> On Wed, Nov 4, 2020 at 2:16 PM Jeff King <firstname.lastname@example.org> wrote: > On Wed, Nov 04, 2020 at 12:27:30PM -0500, Eric Sunshine wrote: > > The commit message's justification for supporting --output seems > > reasonable. However, my knee-jerk reaction to the implementation was > > that it feels overly magical and a bit too hacky. I can see the logic > > in it but it also leaves a bad taste when the implementation has to > > "undo" a side-effect of some other piece of code, which makes it feel > > unplanned and fragile. [...] > > FWIW, that unsetting of rev.diffopt.close_file is exactly how git-log > does it. So while I agree it's a bit ugly, this is the intended way for > --output to be used across multiple diffs, and with log_tree_commit(). > I'd prefer to go this way for now, and if somebody wants to make it less > ugly, they can clean up all of the callers in one go. If you intend to re-roll, it might make sense to include this explanation in the commit message since existing precedent helps sell the ugliness (bad taste), making for a less negative knee-jerk reaction.
next prev parent reply other threads:[~2020-11-04 20:16 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-04 10:18 [Bug report] Crash when creating patch Johannes Postler 2020-11-04 13:24 ` Jeff King 2020-11-04 13:25 ` [PATCH 1/3] format-patch: refactor output selection Jeff King 2020-11-04 17:01 ` Eric Sunshine 2020-11-04 17:13 ` Jeff King 2020-11-04 13:27 ` [PATCH 2/3] format-patch: tie file-opening logic to output_directory Jeff King 2020-11-04 17:03 ` Eric Sunshine 2020-11-04 13:29 ` [PATCH 3/3] format-patch: support --output option Jeff King 2020-11-04 17:27 ` Eric Sunshine 2020-11-04 19:15 ` Jeff King 2020-11-04 20:16 ` Eric Sunshine [this message] 2020-11-04 18:00 ` Junio C Hamano 2020-11-04 19:26 ` [PATCH v2] format-patch --output Jeff King 2020-11-04 19:28 ` [PATCH v2 1/3] format-patch: refactor output selection Jeff King 2020-11-04 19:28 ` [PATCH v2 2/3] format-patch: tie file-opening logic to output_directory Jeff King 2020-11-04 19:28 ` [PATCH v2 3/3] format-patch: support --output option Jeff King 2020-11-05 6:30 ` [PATCH v2] format-patch --output Johannes Postler
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAPig+cSOB+raZHEpSeqnZZ-VHNqLqVyrfVUA8fCr97mv8oSBFw@mail.gmail.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 3/3] format-patch: support --output option' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).