From: Eric Sunshine <sunshine@sunshineco.com>
To: Jeff King <peff@peff.net>
Cc: Johannes Postler <johannes.postler@txture.io>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH 2/3] format-patch: tie file-opening logic to output_directory
Date: Wed, 4 Nov 2020 12:03:22 -0500 [thread overview]
Message-ID: <CAPig+cT8BTTwcORWB1zNWFy8DaohyibWFxojDiU-Na933abRqA@mail.gmail.com> (raw)
In-Reply-To: <20201104132737.GB3030146@coredump.intra.peff.net>
On Wed, Nov 4, 2020 at 8:27 AM Jeff King <peff@peff.net> wrote:
> In format-patch we're either outputting to stdout or to individual files
> in an output directory (which maybe just "./"). Our logic for whether to
s/maybe/may be/
> open a new file for each patch is checked with "!use_stdout", but it is
> equally correct to check for a non-NULL output_directory.
>
> The distinction will matter when we add a new single-stream output in a
> future patch, when only one of the three methods will want individual
> files. Let's swap the logic here in preparation.
>
> Signed-off-by: Jeff King <peff@peff.net>
next prev parent reply other threads:[~2020-11-04 17:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 10:18 [Bug report] Crash when creating patch Johannes Postler
2020-11-04 13:24 ` Jeff King
2020-11-04 13:25 ` [PATCH 1/3] format-patch: refactor output selection Jeff King
2020-11-04 17:01 ` Eric Sunshine
2020-11-04 17:13 ` Jeff King
2020-11-04 13:27 ` [PATCH 2/3] format-patch: tie file-opening logic to output_directory Jeff King
2020-11-04 17:03 ` Eric Sunshine [this message]
2020-11-04 13:29 ` [PATCH 3/3] format-patch: support --output option Jeff King
2020-11-04 17:27 ` Eric Sunshine
2020-11-04 19:15 ` Jeff King
2020-11-04 20:16 ` Eric Sunshine
2020-11-04 18:00 ` Junio C Hamano
2020-11-04 19:26 ` [PATCH v2] format-patch --output Jeff King
2020-11-04 19:28 ` [PATCH v2 1/3] format-patch: refactor output selection Jeff King
2020-11-04 19:28 ` [PATCH v2 2/3] format-patch: tie file-opening logic to output_directory Jeff King
2020-11-04 19:28 ` [PATCH v2 3/3] format-patch: support --output option Jeff King
2020-11-05 6:30 ` [PATCH v2] format-patch --output Johannes Postler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cT8BTTwcORWB1zNWFy8DaohyibWFxojDiU-Na933abRqA@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=johannes.postler@txture.io \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).