ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
* [ruby-core:92484] [Ruby trunk Bug#15812] Run specs from install folder?
       [not found] <redmine.issue-15812.20190429211406@ruby-lang.org>
@ 2019-04-29 21:14 ` Greg.mpls
  2019-04-30 12:43 ` [ruby-core:92493] " eregontp
  2019-07-29 11:14 ` [ruby-core:93997] [Ruby master " eregontp
  2 siblings, 0 replies; 3+ messages in thread
From: Greg.mpls @ 2019-04-29 21:14 UTC (permalink / raw)
  To: ruby-core

Issue #15812 has been reported by MSP-Greg (Greg L).

----------------------------------------
Bug #15812: Run specs from install folder?
https://bugs.ruby-lang.org/issues/15812

* Author: MSP-Greg (Greg L)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
1. Currently, no testing is done on the install folder.
2. Configure/build & testing both take far longer than install
3. spec tests normally run directly in their repo (ruby/spec)

GitHub PR 2160 https://github.com/ruby/ruby/pull/2160 runs the spec suite from the install folder for the three windows builds.  All passed, and the tests were run parallel.


Given that the purpose is to create a functioning install folder, maybe a first step would be runnig specs from there?





-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [ruby-core:92493] [Ruby trunk Bug#15812] Run specs from install folder?
       [not found] <redmine.issue-15812.20190429211406@ruby-lang.org>
  2019-04-29 21:14 ` [ruby-core:92484] [Ruby trunk Bug#15812] Run specs from install folder? Greg.mpls
@ 2019-04-30 12:43 ` eregontp
  2019-07-29 11:14 ` [ruby-core:93997] [Ruby master " eregontp
  2 siblings, 0 replies; 3+ messages in thread
From: eregontp @ 2019-04-30 12:43 UTC (permalink / raw)
  To: ruby-core

Issue #15812 has been updated by Eregon (Benoit Daloze).


I wholeheartedly agree with that.
Supporting running specs from the non-installed Ruby is significant work and hacks.
And testing what people use in production rather than a temporary build is of course much more meaningful.

But I don't think many people agree to require running `install` to run specs/tests, unfortunately, see #13620.
Maybe we should do so that `make` creates an install-like layout in the first place with the build paths to e.g. libruby,
so that we can run tests there without e.g., needing miniruby and tool/run-ruby.rb?

We could require running tests from the install directory only for Windows if people agree.

> spec tests normally run directly in their repo (ruby/spec)

They don't need to, it's perfectly fine to run specs from the copy under spec/ruby in the ruby repository.

----------------------------------------
Bug #15812: Run specs from install folder?
https://bugs.ruby-lang.org/issues/15812#change-77844

* Author: MSP-Greg (Greg L)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
1. Currently, no testing is done on the install folder.
2. Configure/build & testing both take far longer than install
3. spec tests normally run directly in their repo (ruby/spec)

GitHub PR 2160 https://github.com/ruby/ruby/pull/2160 runs the spec suite from the install folder for the three windows builds.  All passed, and the tests were run parallel.


Given that the purpose is to create a functioning install folder, maybe a first step would be runnig specs from there?





-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [ruby-core:93997] [Ruby master Bug#15812] Run specs from install folder?
       [not found] <redmine.issue-15812.20190429211406@ruby-lang.org>
  2019-04-29 21:14 ` [ruby-core:92484] [Ruby trunk Bug#15812] Run specs from install folder? Greg.mpls
  2019-04-30 12:43 ` [ruby-core:92493] " eregontp
@ 2019-07-29 11:14 ` eregontp
  2 siblings, 0 replies; 3+ messages in thread
From: eregontp @ 2019-07-29 11:14 UTC (permalink / raw)
  To: ruby-core

Issue #15812 has been updated by Eregon (Benoit Daloze).

Assignee set to Eregon (Benoit Daloze)
Status changed from Open to Closed

@MSP-Greg I think it's OK to run specs after make-install if that is somehow better in CI.

I'd like to only support running specs on installed Ruby, but that's a separate issue: #13620.

I saw that you closed https://github.com/ruby/ruby/pull/2160.
Tell me if you want to add such a change, I can merge it.

I'll close this issue since the PR was closed, but please comment if you want it again.

----------------------------------------
Bug #15812: Run specs from install folder?
https://bugs.ruby-lang.org/issues/15812#change-80192

* Author: MSP-Greg (Greg L)
* Status: Closed
* Priority: Normal
* Assignee: Eregon (Benoit Daloze)
* Target version: 
* ruby -v: 
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
1. Currently, no testing is done on the install folder.
2. Configure/build & testing both take far longer than install
3. spec tests normally run directly in their repo (ruby/spec)

GitHub PR 2160 https://github.com/ruby/ruby/pull/2160 runs the spec suite from the install folder for the three windows builds.  All passed, and the tests were run parallel.


Given that the purpose is to create a functioning install folder, maybe a first step would be runnig specs from there?





-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-07-29 11:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <redmine.issue-15812.20190429211406@ruby-lang.org>
2019-04-29 21:14 ` [ruby-core:92484] [Ruby trunk Bug#15812] Run specs from install folder? Greg.mpls
2019-04-30 12:43 ` [ruby-core:92493] " eregontp
2019-07-29 11:14 ` [ruby-core:93997] [Ruby master " eregontp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).