From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 570E81F453 for ; Tue, 30 Apr 2019 12:43:36 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 007A0120A81; Tue, 30 Apr 2019 21:43:30 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 9A30C120A64 for ; Tue, 30 Apr 2019 21:43:27 +0900 (JST) Received: by filter0080p3mdw1.sendgrid.net with SMTP id filter0080p3mdw1-15937-5CC842EF-35 2019-04-30 12:43:27.637415972 +0000 UTC m=+404583.034188195 Received: from herokuapp.com (unknown [3.86.82.84]) by ismtpd0010p1iad2.sendgrid.net (SG) with ESMTP id KHJ1zcxWSvy0rJbqWxWNDw for ; Tue, 30 Apr 2019 12:43:27.502 +0000 (UTC) Date: Tue, 30 Apr 2019 12:43:27 +0000 (UTC) From: eregontp@gmail.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 67976 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 15812 X-Redmine-Issue-Author: MSP-Greg X-Redmine-Sender: Eregon X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?KippOI8ZHtTweq7XfQzW93937kJ4QNWwSBuHnaMEcr0MF7iB1=2FUzOsqosxLVWR?= =?us-ascii?Q?2sGmz7BQB=2FnPPWvjm0+liBRIOLMgcT3E0KZFni5?= =?us-ascii?Q?snsH7u2gvhPkKhB87QEyrabgJhvMpMbJID6yM7j?= =?us-ascii?Q?ceT5CJIxvCPnk34ay+iXXQ7PxrO9N2b5dAWyR6H?= =?us-ascii?Q?M=2Fv7aHvmJfelIzDJ0Vme6kKIViIxMVmo+mw=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 92493 Subject: [ruby-core:92493] [Ruby trunk Bug#15812] Run specs from install folder? X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #15812 has been updated by Eregon (Benoit Daloze). I wholeheartedly agree with that. Supporting running specs from the non-installed Ruby is significant work and hacks. And testing what people use in production rather than a temporary build is of course much more meaningful. But I don't think many people agree to require running `install` to run specs/tests, unfortunately, see #13620. Maybe we should do so that `make` creates an install-like layout in the first place with the build paths to e.g. libruby, so that we can run tests there without e.g., needing miniruby and tool/run-ruby.rb? We could require running tests from the install directory only for Windows if people agree. > spec tests normally run directly in their repo (ruby/spec) They don't need to, it's perfectly fine to run specs from the copy under spec/ruby in the ruby repository. ---------------------------------------- Bug #15812: Run specs from install folder? https://bugs.ruby-lang.org/issues/15812#change-77844 * Author: MSP-Greg (Greg L) * Status: Open * Priority: Normal * Assignee: * Target version: * ruby -v: * Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN ---------------------------------------- 1. Currently, no testing is done on the install folder. 2. Configure/build & testing both take far longer than install 3. spec tests normally run directly in their repo (ruby/spec) GitHub PR 2160 https://github.com/ruby/ruby/pull/2160 runs the spec suite from the install folder for the three windows builds. All passed, and the tests were run parallel. Given that the purpose is to create a functioning install folder, maybe a first step would be runnig specs from there? -- https://bugs.ruby-lang.org/