From: eregontp@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:92493] [Ruby trunk Bug#15812] Run specs from install folder?
Date: Tue, 30 Apr 2019 12:43:27 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-77844.20190430124327.492a2d9ea7abcfb9@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-15812.20190429211406@ruby-lang.org
Issue #15812 has been updated by Eregon (Benoit Daloze).
I wholeheartedly agree with that.
Supporting running specs from the non-installed Ruby is significant work and hacks.
And testing what people use in production rather than a temporary build is of course much more meaningful.
But I don't think many people agree to require running `install` to run specs/tests, unfortunately, see #13620.
Maybe we should do so that `make` creates an install-like layout in the first place with the build paths to e.g. libruby,
so that we can run tests there without e.g., needing miniruby and tool/run-ruby.rb?
We could require running tests from the install directory only for Windows if people agree.
> spec tests normally run directly in their repo (ruby/spec)
They don't need to, it's perfectly fine to run specs from the copy under spec/ruby in the ruby repository.
----------------------------------------
Bug #15812: Run specs from install folder?
https://bugs.ruby-lang.org/issues/15812#change-77844
* Author: MSP-Greg (Greg L)
* Status: Open
* Priority: Normal
* Assignee:
* Target version:
* ruby -v:
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
1. Currently, no testing is done on the install folder.
2. Configure/build & testing both take far longer than install
3. spec tests normally run directly in their repo (ruby/spec)
GitHub PR 2160 https://github.com/ruby/ruby/pull/2160 runs the spec suite from the install folder for the three windows builds. All passed, and the tests were run parallel.
Given that the purpose is to create a functioning install folder, maybe a first step would be runnig specs from there?
--
https://bugs.ruby-lang.org/
next prev parent reply other threads:[~2019-04-30 12:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-15812.20190429211406@ruby-lang.org>
2019-04-29 21:14 ` [ruby-core:92484] [Ruby trunk Bug#15812] Run specs from install folder? Greg.mpls
2019-04-30 12:43 ` eregontp [this message]
2019-07-29 11:14 ` [ruby-core:93997] [Ruby master " eregontp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-77844.20190430124327.492a2d9ea7abcfb9@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).