[ruby-core:71520] [Ruby trunk - Bug #11702] [Open] errors in tests of logger

[ruby-core:71520] [Ruby trunk - Bug #11702] [Open] errors in tests of logger

[usa]

Issue #11702 has been reported by Usaku NAKAMURA.

----------------------------------------
Bug #11702: errors in tests of logger 
https://bugs.ruby-lang.org/issues/11702

* Author: Usaku NAKAMURA
* Status: Open
* Priority: Normal
* Assignee: 
* ruby -v: ruby 2.3.0dev (2015-11-17 trunk 52620) [x64-mswin64_100]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
Hi, sonots, welcome to ruby committers!

Your memorial first commit r52620 introduces two test errors on Windows.
Line 134 and 157 of test/logger/test_logdevice.rb is:

```
    File.unlink(@filename) if File.exist?(@filename) # remove once, then reopen
```

but Windows cannot remove opened file.
Fix them, please.
If I will discover that they won't have been fixed on tomorrow morning, I will revert the commit.



-- 
https://bugs.ruby-lang.org/

[ruby-core:71521] [Ruby trunk - Bug #11702] [Assigned] errors in tests of logger on Windows

[usa]

Issue #11702 has been updated by Usaku NAKAMURA.

Subject changed from errors in tests of logger  to errors in tests of logger on Windows
Status changed from Open to Assigned
Assignee set to Naotoshi Seo

----------------------------------------
Bug #11702: errors in tests of logger on Windows
https://bugs.ruby-lang.org/issues/11702#change-54897

* Author: Usaku NAKAMURA
* Status: Assigned
* Priority: Normal
* Assignee: Naotoshi Seo
* ruby -v: ruby 2.3.0dev (2015-11-17 trunk 52620) [x64-mswin64_100]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
Hi, sonots, welcome to ruby committers!

Your memorial first commit r52620 introduces two test errors on Windows.
Line 134 and 157 of test/logger/test_logdevice.rb is:

```
    File.unlink(@filename) if File.exist?(@filename) # remove once, then reopen
```

but Windows cannot remove opened file.
Fix them, please.
If I will discover that they won't have been fixed on tomorrow morning, I will revert the commit.



-- 
https://bugs.ruby-lang.org/

[ruby-core:71522] [Ruby trunk - Bug #11702] errors in tests of logger on Windows

[usa]

Issue #11702 has been updated by Usaku NAKAMURA.


One more request.
Date and time of the entry of ChangeLog is not a date and time that you have made the changes,
but the timing of commit to the repository of ruby.

----------------------------------------
Bug #11702: errors in tests of logger on Windows
https://bugs.ruby-lang.org/issues/11702#change-54898

* Author: Usaku NAKAMURA
* Status: Assigned
* Priority: Normal
* Assignee: Naotoshi Seo
* ruby -v: ruby 2.3.0dev (2015-11-17 trunk 52620) [x64-mswin64_100]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
Hi, sonots, welcome to ruby committers!

Your memorial first commit r52620 introduces two test errors on Windows.
Line 134 and 157 of test/logger/test_logdevice.rb is:

```
    File.unlink(@filename) if File.exist?(@filename) # remove once, then reopen
```

but Windows cannot remove opened file.
Fix them, please.
If I will discover that they won't have been fixed on tomorrow morning, I will revert the commit.



-- 
https://bugs.ruby-lang.org/

[ruby-core:71523] [Ruby trunk - Bug #11702] errors in tests of logger on Windows

[sonots]

Issue #11702 has been updated by Naotoshi Seo.


Oh, god. Thank you for pointing out. I will fix soon. 

----------------------------------------
Bug #11702: errors in tests of logger on Windows
https://bugs.ruby-lang.org/issues/11702#change-54899

* Author: Usaku NAKAMURA
* Status: Assigned
* Priority: Normal
* Assignee: Naotoshi Seo
* ruby -v: ruby 2.3.0dev (2015-11-17 trunk 52620) [x64-mswin64_100]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
Hi, sonots, welcome to ruby committers!

Your memorial first commit r52620 introduces two test errors on Windows.
Line 134 and 157 of test/logger/test_logdevice.rb is:

```
    File.unlink(@filename) if File.exist?(@filename) # remove once, then reopen
```

but Windows cannot remove opened file.
Fix them, please.
If I will discover that they won't have been fixed on tomorrow morning, I will revert the commit.



-- 
https://bugs.ruby-lang.org/

[ruby-core:71524] [Ruby trunk - Bug #11702] errors in tests of logger on Windows

[sonots]

Issue #11702 has been updated by Naotoshi Seo.


@Usaku Nakamura

I created a patch > https://github.com/sonots/ruby/commit/e438ac0b59bf70946947ee80a0f3aa82ef10cf9c. Cloud you check this?

I tried to create a build environment for Windows, but unfortunately it failed as https://gist.github.com/sonots/49e1830d7db19aef505b, and I could not verify by myself. 

----------------------------------------
Bug #11702: errors in tests of logger on Windows
https://bugs.ruby-lang.org/issues/11702#change-54904

* Author: Usaku NAKAMURA
* Status: Assigned
* Priority: Normal
* Assignee: Naotoshi Seo
* ruby -v: ruby 2.3.0dev (2015-11-17 trunk 52620) [x64-mswin64_100]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
Hi, sonots, welcome to ruby committers!

Your memorial first commit r52620 introduces two test errors on Windows.
Line 134 and 157 of test/logger/test_logdevice.rb is:

```
    File.unlink(@filename) if File.exist?(@filename) # remove once, then reopen
```

but Windows cannot remove opened file.
Fix them, please.
If I will discover that they won't have been fixed on tomorrow morning, I will revert the commit.



-- 
https://bugs.ruby-lang.org/

[ruby-core:71533] [Ruby trunk - Bug #11702] errors in tests of logger on Windows

[usa]

Issue #11702 has been updated by Usaku NAKAMURA.


Naotoshi Seo wrote:
> I created a patch > https://github.com/sonots/ruby/commit/e438ac0b59bf70946947ee80a0f3aa82ef10cf9c. Cloud you check this?

Seems OK.
Commit it, please.


> I tried to create a build environment for Windows, but unfortunately it failed as https://gist.github.com/sonots/49e1830d7db19aef505b, and I could not verify by myself.

Current trunk does NOT support VS2015.
Naruse-san tried before, and the results is here: https://github.com/nurse/ruby/tree/msvc14
But, IMO, you should try vs2013 or mingw, unless you want to be maintain vs2015 build.

----------------------------------------
Bug #11702: errors in tests of logger on Windows
https://bugs.ruby-lang.org/issues/11702#change-54912

* Author: Usaku NAKAMURA
* Status: Assigned
* Priority: Normal
* Assignee: Naotoshi Seo
* ruby -v: ruby 2.3.0dev (2015-11-17 trunk 52620) [x64-mswin64_100]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
Hi, sonots, welcome to ruby committers!

Your memorial first commit r52620 introduces two test errors on Windows.
Line 134 and 157 of test/logger/test_logdevice.rb is:

```
    File.unlink(@filename) if File.exist?(@filename) # remove once, then reopen
```

but Windows cannot remove opened file.
Fix them, please.
If I will discover that they won't have been fixed on tomorrow morning, I will revert the commit.



-- 
https://bugs.ruby-lang.org/

[ruby-core:71535] [Ruby trunk - Bug #11702] errors in tests of logger on Windows

[sonots]

Issue #11702 has been updated by Naotoshi Seo.


Thanks, I will try with vs2013, but anyway committed :)

----------------------------------------
Bug #11702: errors in tests of logger on Windows
https://bugs.ruby-lang.org/issues/11702#change-54915

* Author: Usaku NAKAMURA
* Status: Closed
* Priority: Normal
* Assignee: Naotoshi Seo
* ruby -v: ruby 2.3.0dev (2015-11-17 trunk 52620) [x64-mswin64_100]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
Hi, sonots, welcome to ruby committers!

Your memorial first commit r52620 introduces two test errors on Windows.
Line 134 and 157 of test/logger/test_logdevice.rb is:

```
    File.unlink(@filename) if File.exist?(@filename) # remove once, then reopen
```

but Windows cannot remove opened file.
Fix them, please.
If I will discover that they won't have been fixed on tomorrow morning, I will revert the commit.



-- 
https://bugs.ruby-lang.org/