[ruby-core:71533] [Ruby trunk - Bug #11702] errors in tests of logger on Windows

[usa@garbagecollect.jp]

Issue #11702 has been updated by Usaku NAKAMURA.


Naotoshi Seo wrote:
> I created a patch > https://github.com/sonots/ruby/commit/e438ac0b59bf70946947ee80a0f3aa82ef10cf9c. Cloud you check this?

Seems OK.
Commit it, please.


> I tried to create a build environment for Windows, but unfortunately it failed as https://gist.github.com/sonots/49e1830d7db19aef505b, and I could not verify by myself.

Current trunk does NOT support VS2015.
Naruse-san tried before, and the results is here: https://github.com/nurse/ruby/tree/msvc14
But, IMO, you should try vs2013 or mingw, unless you want to be maintain vs2015 build.

----------------------------------------
Bug #11702: errors in tests of logger on Windows
https://bugs.ruby-lang.org/issues/11702#change-54912

* Author: Usaku NAKAMURA
* Status: Assigned
* Priority: Normal
* Assignee: Naotoshi Seo
* ruby -v: ruby 2.3.0dev (2015-11-17 trunk 52620) [x64-mswin64_100]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
Hi, sonots, welcome to ruby committers!

Your memorial first commit r52620 introduces two test errors on Windows.
Line 134 and 157 of test/logger/test_logdevice.rb is:

```
    File.unlink(@filename) if File.exist?(@filename) # remove once, then reopen
```

but Windows cannot remove opened file.
Fix them, please.
If I will discover that they won't have been fixed on tomorrow morning, I will revert the commit.



-- 
https://bugs.ruby-lang.org/