From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id C2C1019C001F for ; Wed, 18 Nov 2015 08:19:47 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 6D901B5D8C3 for ; Wed, 18 Nov 2015 08:50:22 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 7E2A918CC7D0 for ; Wed, 18 Nov 2015 08:50:22 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 40EF0120487; Wed, 18 Nov 2015 08:50:20 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o10.shared.sendgrid.net (o10.shared.sendgrid.net [173.193.132.135]) by neon.ruby-lang.org (Postfix) with ESMTPS id 2E595120470 for ; Wed, 18 Nov 2015 08:50:16 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=eNDh2ynH5pmyf0A928jPVgkeNkk=; b=DyVorl1hpvpfPmOFTP t4DP/XM2u2EZW2Et9abmiMADOHzSWY5soe8c/axCuLYQxRn3I1rprpoqEvaTQe81 mmdOKhY6DcMsBv6OUDmpxUvyZ3E/Ybyu6u+L+wd3B6FmAeoK7TDhIrdkBItP5RcX thUP2Z/8FbLCbfDeKzOrHUVPY= Received: by filter0642p1mdw1.sendgrid.net with SMTP id filter0642p1mdw1.2514.564BBD3534 2015-11-17 23:50:13.61650718 +0000 UTC Received: from herokuapp.com (ec2-54-144-225-166.compute-1.amazonaws.com [54.144.225.166]) by ismtpd0001p1iad1.sendgrid.net (SG) with ESMTP id WKIsiAS2RxySdvfWmPBGng for ; Tue, 17 Nov 2015 23:50:13.518 +0000 (UTC) Date: Tue, 17 Nov 2015 23:50:13 +0000 From: usa@garbagecollect.jp To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 46195 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11702 X-Redmine-Issue-Author: usa X-Redmine-Issue-Assignee: sonots X-Redmine-Sender: usa X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS7789fduKdmaNZE3w6ipzPftK+zUkVN1KKs+Q NyhAhSGgmnTbMttpK7i6b/3aq5lk+U/du4fX/xsbWN5377AqOJQIE0+gQhylgl/MC3cmyEusiZJf6F Is5WQsaSeiYtw6x8fzY/aQFtRhKIciXkmybM X-ML-Name: ruby-core X-Mail-Count: 71533 Subject: [ruby-core:71533] [Ruby trunk - Bug #11702] errors in tests of logger on Windows X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11702 has been updated by Usaku NAKAMURA. Naotoshi Seo wrote: > I created a patch > https://github.com/sonots/ruby/commit/e438ac0b59bf70946947ee80a0f3aa82ef10cf9c. Cloud you check this? Seems OK. Commit it, please. > I tried to create a build environment for Windows, but unfortunately it failed as https://gist.github.com/sonots/49e1830d7db19aef505b, and I could not verify by myself. Current trunk does NOT support VS2015. Naruse-san tried before, and the results is here: https://github.com/nurse/ruby/tree/msvc14 But, IMO, you should try vs2013 or mingw, unless you want to be maintain vs2015 build. ---------------------------------------- Bug #11702: errors in tests of logger on Windows https://bugs.ruby-lang.org/issues/11702#change-54912 * Author: Usaku NAKAMURA * Status: Assigned * Priority: Normal * Assignee: Naotoshi Seo * ruby -v: ruby 2.3.0dev (2015-11-17 trunk 52620) [x64-mswin64_100] * Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN ---------------------------------------- Hi, sonots, welcome to ruby committers! Your memorial first commit r52620 introduces two test errors on Windows. Line 134 and 157 of test/logger/test_logdevice.rb is: ``` File.unlink(@filename) if File.exist?(@filename) # remove once, then reopen ``` but Windows cannot remove opened file. Fix them, please. If I will discover that they won't have been fixed on tomorrow morning, I will revert the commit. -- https://bugs.ruby-lang.org/