* [ruby-core:81590] Re: [ruby-cvs:66197] ko1:r59023 (trunk): revert r59020 because it may fail some tests sometimes on some environment (http://ci.rvm.jp/). This revert is to check the reason of failures.
[not found] <20170606065854.7F44567833@svn.ruby-lang.org>
@ 2017-06-06 18:40 ` Eric Wong
2017-06-06 18:58 ` [ruby-core:81591] " Eric Wong
0 siblings, 1 reply; 5+ messages in thread
From: Eric Wong @ 2017-06-06 18:40 UTC (permalink / raw)
To: ko1, ruby-core; +Cc: ruby-cvs
ko1@ruby-lang.org wrote:
> ko1 2017-06-06 15:58:54 +0900 (Tue, 06 Jun 2017)
>
> New Revision: 59023
>
> https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=59023
>
> Log:
> revert r59020 because it may fail some tests sometimes on some environment (http://ci.rvm.jp/). This revert is to check the reason of failures.
Any progress on tracking these failures? I suspect there are
existing bugs which r59020 exposed, causing the failures.
I will check the IO#gets and buffering code, too.
Initial investigation shows r57224 looks like it may lose data...
^ permalink raw reply [flat|nested] 5+ messages in thread
* [ruby-core:81591] Re: [ruby-cvs:66197] ko1:r59023 (trunk): revert r59020 because it may fail some tests sometimes on some environment (http://ci.rvm.jp/). This revert is to check the reason of failures.
2017-06-06 18:40 ` [ruby-core:81590] Re: [ruby-cvs:66197] ko1:r59023 (trunk): revert r59020 because it may fail some tests sometimes on some environment (http://ci.rvm.jp/). This revert is to check the reason of failures Eric Wong
@ 2017-06-06 18:58 ` Eric Wong
2017-06-06 22:57 ` [ruby-core:81596] Re: [ruby-cvs:66203] Re: " Eric Wong
0 siblings, 1 reply; 5+ messages in thread
From: Eric Wong @ 2017-06-06 18:58 UTC (permalink / raw)
To: ko1, ruby-core; +Cc: ruby-cvs
Eric Wong <normalperson@yhbt.net> wrote:
> ko1@ruby-lang.org wrote:
> > ko1 2017-06-06 15:58:54 +0900 (Tue, 06 Jun 2017)
> >
> > New Revision: 59023
> >
> > https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=59023
> >
> > Log:
> > revert r59020 because it may fail some tests sometimes on some environment (http://ci.rvm.jp/). This revert is to check the reason of failures.
>
> Any progress on tracking these failures? I suspect there are
> existing bugs which r59020 exposed, causing the failures.
> I will check the IO#gets and buffering code, too.
>
> Initial investigation shows r57224 looks like it may lose data...
Ah, r59020 interacts badly with r57422.
I think the API for close notification (and FD waiting)
needs to be reworked to avoid races in MT.
On a related note, the new C API in [Feature #13618] (auto
fiber) uses "int *fd" and "rb_io_t *fptr" (not "int fd") to
avoid race conditions, but I think there is more work to
be done in MT.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [ruby-core:81596] Re: [ruby-cvs:66203] Re: Re: ko1:r59023 (trunk): revert r59020 because it may fail some tests sometimes on some environment (http://ci.rvm.jp/). This revert is to check the reason of failures.
2017-06-06 18:58 ` [ruby-core:81591] " Eric Wong
@ 2017-06-06 22:57 ` Eric Wong
2017-06-06 23:08 ` [ruby-core:81598] " SASADA Koichi
0 siblings, 1 reply; 5+ messages in thread
From: Eric Wong @ 2017-06-06 22:57 UTC (permalink / raw)
To: ko1, ruby-core, ruby-cvs
Eric Wong <normalperson@yhbt.net> wrote:
> Ah, r59020 interacts badly with r57422.
I made r59028, now. However, I suspect our fd close
notification is fragile and can be fixed further. I will
continue investigating another time.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [ruby-core:81598] Re: [ruby-cvs:66203] Re: Re: ko1:r59023 (trunk): revert r59020 because it may fail some tests sometimes on some environment (http://ci.rvm.jp/). This revert is to check the reason of failures.
2017-06-06 22:57 ` [ruby-core:81596] Re: [ruby-cvs:66203] Re: " Eric Wong
@ 2017-06-06 23:08 ` SASADA Koichi
2017-06-08 1:51 ` [ruby-core:81614] " SASADA Koichi
0 siblings, 1 reply; 5+ messages in thread
From: SASADA Koichi @ 2017-06-06 23:08 UTC (permalink / raw)
To: Ruby developers
On 2017/06/07 7:57, Eric Wong wrote:
> I made r59028, now. However, I suspect our fd close
> notification is fragile and can be fixed further. I will
> continue investigating another time.
Thank you! I'll check the test results.
--
// SASADA Koichi at atdot dot net
^ permalink raw reply [flat|nested] 5+ messages in thread
* [ruby-core:81614] Re: [ruby-cvs:66203] Re: Re: ko1:r59023 (trunk): revert r59020 because it may fail some tests sometimes on some environment (http://ci.rvm.jp/). This revert is to check the reason of failures.
2017-06-06 23:08 ` [ruby-core:81598] " SASADA Koichi
@ 2017-06-08 1:51 ` SASADA Koichi
0 siblings, 0 replies; 5+ messages in thread
From: SASADA Koichi @ 2017-06-08 1:51 UTC (permalink / raw)
To: Ruby developers
http://ci.rvm.jp/
no trouble!
Thank you.
On 2017/06/07 8:08, SASADA Koichi wrote:
> On 2017/06/07 7:57, Eric Wong wrote:
>> I made r59028, now. However, I suspect our fd close
>> notification is fragile and can be fixed further. I will
>> continue investigating another time.
>
> Thank you! I'll check the test results.
>
--
// SASADA Koichi at atdot dot net
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-06-08 1:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20170606065854.7F44567833@svn.ruby-lang.org>
2017-06-06 18:40 ` [ruby-core:81590] Re: [ruby-cvs:66197] ko1:r59023 (trunk): revert r59020 because it may fail some tests sometimes on some environment (http://ci.rvm.jp/). This revert is to check the reason of failures Eric Wong
2017-06-06 18:58 ` [ruby-core:81591] " Eric Wong
2017-06-06 22:57 ` [ruby-core:81596] Re: [ruby-cvs:66203] Re: " Eric Wong
2017-06-06 23:08 ` [ruby-core:81598] " SASADA Koichi
2017-06-08 1:51 ` [ruby-core:81614] " SASADA Koichi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).