From: Eric Wong <normalperson@yhbt.net>
To: ko1@ruby-lang.org, ruby-core@ruby-lang.org
Cc: ruby-cvs@ruby-lang.org
Subject: [ruby-core:81591] Re: [ruby-cvs:66197] ko1:r59023 (trunk): revert r59020 because it may fail some tests sometimes on some environment (http://ci.rvm.jp/). This revert is to check the reason of failures.
Date: Tue, 6 Jun 2017 18:58:49 +0000 [thread overview]
Message-ID: <20170606185849.GB3503@starla> (raw)
In-Reply-To: <20170606184000.GA3503@starla>
Eric Wong <normalperson@yhbt.net> wrote:
> ko1@ruby-lang.org wrote:
> > ko1 2017-06-06 15:58:54 +0900 (Tue, 06 Jun 2017)
> >
> > New Revision: 59023
> >
> > https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=59023
> >
> > Log:
> > revert r59020 because it may fail some tests sometimes on some environment (http://ci.rvm.jp/). This revert is to check the reason of failures.
>
> Any progress on tracking these failures? I suspect there are
> existing bugs which r59020 exposed, causing the failures.
> I will check the IO#gets and buffering code, too.
>
> Initial investigation shows r57224 looks like it may lose data...
Ah, r59020 interacts badly with r57422.
I think the API for close notification (and FD waiting)
needs to be reworked to avoid races in MT.
On a related note, the new C API in [Feature #13618] (auto
fiber) uses "int *fd" and "rb_io_t *fptr" (not "int fd") to
avoid race conditions, but I think there is more work to
be done in MT.
next prev parent reply other threads:[~2017-06-06 18:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170606065854.7F44567833@svn.ruby-lang.org>
2017-06-06 18:40 ` [ruby-core:81590] Re: [ruby-cvs:66197] ko1:r59023 (trunk): revert r59020 because it may fail some tests sometimes on some environment (http://ci.rvm.jp/). This revert is to check the reason of failures Eric Wong
2017-06-06 18:58 ` Eric Wong [this message]
2017-06-06 22:57 ` [ruby-core:81596] Re: [ruby-cvs:66203] Re: " Eric Wong
2017-06-06 23:08 ` [ruby-core:81598] " SASADA Koichi
2017-06-08 1:51 ` [ruby-core:81614] " SASADA Koichi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170606185849.GB3503@starla \
--to=ruby-core@ruby-lang.org \
--cc=ko1@ruby-lang.org \
--cc=ruby-cvs@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).