From: Hongli Lai <hongli@phusion.nl>
To: Rack Development <rack-devel@googlegroups.com>
Subject: Re: Not cleaning up tempfiles for multipart?
Date: Sat, 6 Mar 2010 02:20:21 -0800 (PST) [thread overview]
Message-ID: <e833ccdf-9391-4db6-bec2-bc3a9f60266c@t20g2000yqe.googlegroups.com> (raw)
In-Reply-To: <f04d2211003050647k4181af21w6e4a4d3b7e1302d4@mail.gmail.com>
On Mar 5, 3:47 pm, Charles Oliver Nutter <head...@headius.com> wrote:
> I'm also confused by this code in rewindable_input.rb:
>
> class Tempfile < ::Tempfile
> def _close
> @tmpfile.close if @tmpfile
> @data[1] = nil if @data
> @tmpfile = nil
> end
> end
>
> the original _close (in 1.8.7) does this, which should be functionally
> equivalent:
>
> def _close # :nodoc:
> @tmpfile.close if @tmpfile
> @tmpfile = nil
> @data[1] = nil if @data
> end
>
> Is this patching a bug from 1.8.6?
Yes. The following code doesn't work on 1.8.6:
t = Tempfile.new('foo')
t.unlink
t.close # <--- crash, because of the early unlink
next prev parent reply other threads:[~2010-03-06 10:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-05 14:40 Not cleaning up tempfiles for multipart? Charles Oliver Nutter
2010-03-05 14:47 ` Charles Oliver Nutter
2010-03-05 14:48 ` Charles Oliver Nutter
2010-03-06 10:20 ` Hongli Lai [this message]
2010-03-07 14:25 ` Charles Oliver Nutter
2010-03-06 7:55 ` Eric Wong
2010-03-06 10:25 ` Hongli Lai
2010-03-07 14:34 ` Charles Oliver Nutter
2010-03-08 0:22 ` Eric Wong
2010-03-08 1:12 ` Eric Wong
2010-03-17 15:41 ` Charles Oliver Nutter
2010-03-18 9:54 ` Eric Wong
2014-01-06 22:45 ` Wojtek Kruszewski
2014-02-11 21:05 ` Eric Wong
2014-03-27 21:40 ` Lenny Marks
2010-03-07 23:53 ` Eric Wong
2010-03-08 11:26 ` Hongli Lai
2010-03-08 11:30 ` Hongli Lai
2010-03-08 14:33 ` Randy Fischer
2010-03-08 14:43 ` Charles Oliver Nutter
2010-03-08 14:49 ` James Tucker
2010-03-17 2:37 ` Eric Wong
2010-03-08 13:22 ` Charles Oliver Nutter
2010-03-08 14:42 ` James Tucker
2010-03-08 17:24 ` Hongli Lai
2010-03-09 7:43 ` Charles Oliver Nutter
2010-03-08 10:05 ` James Tucker
2010-03-07 14:27 ` Charles Oliver Nutter
2010-03-08 0:18 ` Eric Wong
2010-03-08 10:07 ` James Tucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://groups.google.com/group/rack-devel
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e833ccdf-9391-4db6-bec2-bc3a9f60266c@t20g2000yqe.googlegroups.com \
--to=rack-devel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).