From: Hongli Lai <email@example.com> To: Rack Development <firstname.lastname@example.org> Subject: Re: Not cleaning up tempfiles for multipart? Date: Mon, 8 Mar 2010 09:24:54 -0800 (PST) [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <910BFBA2-7FD4-4985-99CC-A1764EB92179@gmail.com> On Mar 8, 3:42 pm, James Tucker <jftuc...@gmail.com> wrote: > Just to be clear, I don't disagree at all that this needs to be fixed. I think handlers/servers should close any tempfiles they create, and the requirement for middleware should be the same. Glad we're on the same page. :) Phusion Passenger does clean up its own tempfiles. As for the link you posted, I think that's for cleaning up the rack.input buffer file, not multipart files. Charles Nutter: > I don't think it should be specified behavior that a tempfile *ever* > exists on disk. The mechanism of temporary storage for a large > incoming post should be a black box. Consider systems that won't > actually have a writable filesystem, like GAE; there, the "tempfile" > data would be stored in memory or in BigTable. Agreed. However I think it should be *possible* to access the on-disk file directly as an optimization for apps that need it, they just musn't rely on it to be available. For example if your app deals with 2 GB file uploads then you really want to avoid that extra copy when storing the file upload in a storage location on the same filesystem, whenever possible.
next prev parent reply other threads:[~2010-03-08 17:24 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-03-05 14:40 Charles Oliver Nutter 2010-03-05 14:47 ` Charles Oliver Nutter 2010-03-05 14:48 ` Charles Oliver Nutter 2010-03-06 10:20 ` Hongli Lai 2010-03-07 14:25 ` Charles Oliver Nutter 2010-03-06 7:55 ` Eric Wong 2010-03-06 10:25 ` Hongli Lai 2010-03-07 14:34 ` Charles Oliver Nutter 2010-03-08 0:22 ` Eric Wong 2010-03-08 1:12 ` Eric Wong 2010-03-17 15:41 ` Charles Oliver Nutter 2010-03-18 9:54 ` Eric Wong 2014-01-06 22:45 ` Wojtek Kruszewski 2014-02-11 21:05 ` Eric Wong 2014-03-27 21:40 ` Lenny Marks 2010-03-07 23:53 ` Eric Wong 2010-03-08 11:26 ` Hongli Lai 2010-03-08 11:30 ` Hongli Lai 2010-03-08 14:33 ` Randy Fischer 2010-03-08 14:43 ` Charles Oliver Nutter 2010-03-08 14:49 ` James Tucker 2010-03-17 2:37 ` Eric Wong 2010-03-08 13:22 ` Charles Oliver Nutter 2010-03-08 14:42 ` James Tucker 2010-03-08 17:24 ` Hongli Lai [this message] 2010-03-09 7:43 ` Charles Oliver Nutter 2010-03-08 10:05 ` James Tucker 2010-03-07 14:27 ` Charles Oliver Nutter 2010-03-08 0:18 ` Eric Wong 2010-03-08 10:07 ` James Tucker
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-list from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://groups.google.com/group/rack-devel * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: Not cleaning up tempfiles for multipart?' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/rack.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).