From: Joshua Peek <josh@joshpeek.com>
To: rack-devel@googlegroups.com
Subject: Re: Downsizing CommonLogger
Date: Thu, 14 May 2009 09:28:35 -0500 [thread overview]
Message-ID: <1c5622660905140728i3c162e1erf2e3058f79c80357@mail.gmail.com> (raw)
In-Reply-To: <2a8d4a710905132214s1cb24b4brea19d6f684be20c7@mail.gmail.com>
+1
I'll pull it in soon.
On Thu, May 14, 2009 at 12:14 AM, Matt Todd <chiology@gmail.com> wrote:
> +1
>
> On Wed, May 13, 2009 at 9:52 PM, Jeremy Kemper <jeremy@bitsweat.net> wrote:
>>
>> On Wed, Apr 29, 2009 at 8:21 AM, Michael Fellinger
>> <m.fellinger@gmail.com> wrote:
>> >
>> > On Wed, 29 Apr 2009 08:03:09 -0700
>> > Jeremy Kemper <jeremy@bitsweat.net> wrote:
>> >
>> >> CommonLogger calculates the content length itself. This duplicates
>> >> work done by the app or ContentLength middleware.
>> >>
>> >> The middleware is simpler, faster, and generates less garbage per
>> >> request by using the Content-Length header instead.
>> >>
>> >> Patch:
>> >>
>> >> http://github.com/jeremy/rack/commit/f9d38d9d866060be39192675adcc2efc19164c6f
>> >>
>> >> Best,
>> >> jeremy
>> >
>> > +1
>> > I've also long wanted to extract the format string like you did... so +2
>> > actually :)
>> >
>> > --
>> > ^ manveru
>> >
>>
>> This change is still on deck. Attention upstream :)
>>
>> jeremy
>
>
>
> --
> Matt Todd
> Highgroove Studios
> www.highgroove.com
> cell: 404-314-2612
> blog: maraby.org
>
> Scout - Web Monitoring and Reporting Software
> www.scoutapp.com
>
--
Joshua Peek
next prev parent reply other threads:[~2009-05-14 14:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-29 15:03 Downsizing CommonLogger Jeremy Kemper
2009-04-29 15:21 ` Michael Fellinger
2009-05-14 1:52 ` Jeremy Kemper
2009-05-14 5:14 ` Matt Todd
2009-05-14 14:28 ` Joshua Peek [this message]
2009-05-16 8:58 ` Christian Neukirchen
2009-08-12 1:14 ` Eric Wong
2009-08-12 2:38 ` Eric Wong
2009-08-12 21:56 ` Jeremy Kemper
2009-08-13 5:44 ` Eric Wong
2009-08-13 10:14 ` Christian Neukirchen
2009-08-13 16:18 ` Jeremy Kemper
2009-08-13 16:26 ` Jeremy Kemper
2009-08-13 16:30 ` Yehuda Katz
2009-08-13 16:33 ` Brian Lopez
2009-08-13 16:36 ` Jeremy Kemper
2009-08-13 18:43 ` Scytrin dai Kinthra
2009-08-14 3:33 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://groups.google.com/group/rack-devel
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c5622660905140728i3c162e1erf2e3058f79c80357@mail.gmail.com \
--to=rack-devel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).