Re: Downsizing CommonLogger

[Eric Wong <normalperson@yhbt.net>]

Yehuda Katz <wycats@gmail.com> wrote:
> I'm personally quite concerned about trying to figure out the content-length
> in any Rack middleware. It's expensive to do in pure-ruby, and a later
> middleware can mess with the size anyway and be forced to recalculate. I
> think the appropriate place for this calculation is in the actual server
> that sends the data to the client, where it can be done once and in C.
> -- Yehuda

If called in the correct place, the stock ContentLength middleware looks
fine to me, and still easier/faster for clients (especially caches) to
handle.  That said, I consider correct ordering of the middleware stack
to be a requirement anyways.

Of course, chunked transfers (if they're generated on the fly) are
impossible to calculate until the response is finished writing...  I'd
also rather not have my logs bound by whatever server-of-the-day I
happen to be using.

-- 
Eric Wong