Re: Downsizing CommonLogger

[Jeremy Kemper <jeremy@bitsweat.net>]

On Tue, Aug 11, 2009 at 9:38 PM, Eric Wong<normalperson@yhbt.net> wrote:
>
> Eric Wong <normalperson@yhbt.net> wrote:
>> Christian Neukirchen <chneukirchen@gmail.com> wrote:
>> > Joshua Peek <josh@joshpeek.com> writes:
>> >
>> > > I'll pull it in soon.
>> >
>> > Does it log the right size for chunked outputs?  In logfiles, I want those...
>>
>> I'm very late to the party, but no, it doesn't.
>>
>> This also miscalculates request time if the body is being generated
>> dynamically during #each.
>
> I'd rather revert the original patch here for simplicity.
>
> But if the original _dup was too much overhead maybe we can reach a
> middle ground and only fall back to wrapping #each iff there's no
> Content-Length header to be found.
>
> I don't can't find any real applications to benchmark with; but the
> following patch may be considered (try Content-Length first, fallback to
> wrapping body#each):

Hey Eric,

Nice patch, but these changes were intentional. CommonLogger's concern
is logging the request, not calculating content length edge cases or
acting as a benchmarker. I'd advocate removing the timing entirely;
it's not part of the Common Log Format.

Best,
jeremy