From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.204.112.148 with SMTP id w20cs370591bkp; Thu, 14 May 2009 07:28:58 -0700 (PDT) Received-SPF: pass (google.com: domain of grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com designates 10.141.29.8 as permitted sender) client-ip=10.141.29.8; Authentication-Results: mr.google.com; spf=pass (google.com: domain of grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com designates 10.141.29.8 as permitted sender) smtp.mail=grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com; dkim=pass header.i=grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com Received: from mr.google.com ([10.141.29.8]) by 10.141.29.8 with SMTP id g8mr2322471rvj.5.1242311336976 (num_hops = 1); Thu, 14 May 2009 07:28:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:received:x-sender:x-apparently-to :received:received:received-spf:authentication-results:received :dkim-signature:domainkey-signature:mime-version:received :in-reply-to:references:from:date:message-id:subject:to:content-type :content-transfer-encoding:reply-to:sender:precedence:x-google-loop :mailing-list:list-id:list-post:list-help:list-unsubscribe :x-beenthere-env:x-beenthere; bh=NGc/Zd7T9oUJobfMG9rOIiXqxizqNY720AsQXvGaajc=; b=zpt3fGOoTltb1bjpJGJTfjLCFHYuEN6mg3CszmWbrISS5Pk1AY2Gf2Zc7e4I43WoEE yLWBWqxcZTKwzat7sCFw4pzqNdcNCsNF2psig6fdlszEGrvCvrnzgX9oWmO8Qdl7D5nr cSa3JnUUZWq+6f+0++kYsQGl0xerbKMUBlN6U= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-sender:x-apparently-to:received-spf:authentication-results :dkim-signature:domainkey-signature:mime-version:in-reply-to :references:from:date:message-id:subject:to:content-type :content-transfer-encoding:reply-to:sender:precedence:x-google-loop :mailing-list:list-id:list-post:list-help:list-unsubscribe :x-beenthere-env:x-beenthere; b=ntcbCcsL7XC2GVcuoX3n0YKp7tOFeaR6IXIMcBJTnq0NYPTkmFXcaT6fl2EJlRY8Uh KZlF6w/hvrIpwldtVxuakTf8X4ktwItWI3LYq4GPKJ3JKV96jtMBGz5dNULDdJ5qCVLb 0Crl9bv2g6tRlU45AhKxRM1TaglVxCnXuFwOE= Received: by 10.141.29.8 with SMTP id g8mr346725rvj.5.1242311336793; Thu, 14 May 2009 07:28:56 -0700 (PDT) Received: by 10.107.155.38 with SMTP id h38gr1321pro.0; Thu, 14 May 2009 07:28:56 -0700 (PDT) X-Sender: joshpeek@gmail.com X-Apparently-To: rack-devel@googlegroups.com Received: by 10.229.85.15 with SMTP id m15mr535346qcl.6.1242311336240; Thu, 14 May 2009 07:28:56 -0700 (PDT) Return-Path: Received: from mail-qy0-f189.google.com (mail-qy0-f189.google.com [209.85.221.189]) by gmr-mx.google.com with ESMTP id 21si4143qyk.10.2009.05.14.07.28.55; Thu, 14 May 2009 07:28:55 -0700 (PDT) Received-SPF: pass (google.com: domain of joshpeek@gmail.com designates 209.85.221.189 as permitted sender) client-ip=209.85.221.189; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of joshpeek@gmail.com designates 209.85.221.189 as permitted sender) smtp.mail=joshpeek@gmail.com; dkim=pass (test mode) header.i=@gmail.com Received: by mail-qy0-f189.google.com with SMTP id 27so2352074qyk.2 for ; Thu, 14 May 2009 07:28:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:from:date:x-google-sender-auth:message-id:subject:to :content-type:content-transfer-encoding; bh=Ssx2itnVn34VJsRk8jaQbv+SryJ+YevbnKW6Dmwlbls=; b=NdkKNtZQHwr5RaII1bSicj7rO2SzSeIlPFjYOwCmU7ma4Aezv3mYwaX8fOo52568Jg 8v5VrwoiLtJ39VnHuipPG/+9vINiU9ciFQKqfT5yMKwfT0uDtY7mxcrOwmavx6YZH2G8 +QInlZLH0culskRa+M3VP9Ln7mWpwxwyf8HAg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:content-type :content-transfer-encoding; b=iIe0g2O1GUi5CsT9HwsCNaTa/pAlgrkVEiLMx5QtIDJkBi5E0LDvhJfeoLwteEFo0m gBv5Z4nBoqA8qipJIlggrz9RjsZ4v9bYDAAJvSulJkqxSGW3Icy/Idg0Mql14qVmH/Bj 3GIlAgytxqAX9blNwi8tDO8DqHEZSDdpltfTA= MIME-Version: 1.0 Received: by 10.224.20.12 with SMTP id d12mr2723103qab.248.1242311335154; Thu, 14 May 2009 07:28:55 -0700 (PDT) In-Reply-To: <2a8d4a710905132214s1cb24b4brea19d6f684be20c7@mail.gmail.com> References: <69a2885c0904290803j292d2c45j5a46d0e759b6272a@mail.gmail.com> <20090430002127.7bd983f1@sigma.localdomain> <69a2885c0905131852h2ee62731o72337bec5490742e@mail.gmail.com> <2a8d4a710905132214s1cb24b4brea19d6f684be20c7@mail.gmail.com> From: Joshua Peek Date: Thu, 14 May 2009 09:28:35 -0500 Message-ID: <1c5622660905140728i3c162e1erf2e3058f79c80357@mail.gmail.com> Subject: Re: Downsizing CommonLogger To: rack-devel@googlegroups.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Reply-To: rack-devel@googlegroups.com Sender: rack-devel@googlegroups.com Precedence: bulk X-Google-Loop: groups Mailing-List: list rack-devel@googlegroups.com; contact rack-devel+owner@googlegroups.com List-Id: List-Post: List-Help: List-Unsubscribe: , X-BeenThere-Env: rack-devel@googlegroups.com X-BeenThere: rack-devel@googlegroups.com +1 I'll pull it in soon. On Thu, May 14, 2009 at 12:14 AM, Matt Todd wrote: > +1 > > On Wed, May 13, 2009 at 9:52 PM, Jeremy Kemper wrote: >> >> On Wed, Apr 29, 2009 at 8:21 AM, Michael Fellinger >> wrote: >> > >> > On Wed, 29 Apr 2009 08:03:09 -0700 >> > Jeremy Kemper wrote: >> > >> >> CommonLogger calculates the content length itself. This duplicates >> >> work done by the app or ContentLength middleware. >> >> >> >> The middleware is simpler, faster, and generates less garbage per >> >> request by using the Content-Length header instead. >> >> >> >> Patch: >> >> >> >> http://github.com/jeremy/rack/commit/f9d38d9d866060be39192675adcc2efc19164c6f >> >> >> >> Best, >> >> jeremy >> > >> > +1 >> > I've also long wanted to extract the format string like you did... so +2 >> > actually :) >> > >> > -- >> > ^ manveru >> > >> >> This change is still on deck. Attention upstream :) >> >> jeremy > > > > -- > Matt Todd > Highgroove Studios > www.highgroove.com > cell: 404-314-2612 > blog: maraby.org > > Scout - Web Monitoring and Reporting Software > www.scoutapp.com > -- Joshua Peek