From: Eric Wong <e@80x24.org> To: meta@public-inbox.org Subject: [PATCH 19/35] t/psgi_scan_all: create_inbox lots saved Date: Mon, 15 Mar 2021 12:58:10 +0100 [thread overview] Message-ID: <20210315115826.17591-20-e@80x24.org> (raw) In-Reply-To: <20210315115826.17591-1-e@80x24.org> A fair mount of setup code goes away and saves us a few hundred milliseconds. --- t/psgi_scan_all.t | 48 ++++++++++++++++------------------------------- 1 file changed, 16 insertions(+), 32 deletions(-) diff --git a/t/psgi_scan_all.t b/t/psgi_scan_all.t index 80b855e1..09e8eaf9 100644 --- a/t/psgi_scan_all.t +++ b/t/psgi_scan_all.t @@ -1,53 +1,38 @@ +#!perl -w # Copyright (C) 2019-2021 all contributors <meta@public-inbox.org> # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt> use strict; -use warnings; -use Test::More; +use v5.10.1; +use PublicInbox::TestCommon; use PublicInbox::Eml; use PublicInbox::Config; -use PublicInbox::TestCommon; my @mods = qw(HTTP::Request::Common Plack::Test URI::Escape DBD::SQLite); require_git 2.6; require_mods(@mods); -use_ok 'PublicInbox::V2Writable'; +use_ok 'PublicInbox::WWW'; foreach my $mod (@mods) { use_ok $mod; } -my ($tmp, $for_destroy) = tmpdir(); my $cfg = ''; - foreach my $i (1..2) { - my $cfgpfx = "publicinbox.test-$i"; - my $addr = "test-$i\@example.com"; - my $inboxdir = "$tmp/$i"; - $cfg .= "$cfgpfx.address=$addr\n"; - $cfg .= "$cfgpfx.inboxdir=$inboxdir\n"; - $cfg .= "$cfgpfx.url=http://example.com/$i\n"; - my $opt = { - inboxdir => $inboxdir, - name => "test-$i", - version => 2, - indexlevel => 'basic', - -primary_address => $addr, - }; - my $ibx = PublicInbox::Inbox->new($opt); - my $im = PublicInbox::V2Writable->new($ibx, 1); - $im->{parallel} = 0; - $im->init_inbox(0); - my $mime = PublicInbox::Eml->new(<<EOF); + my $ibx = create_inbox "test-$i", version => 2, indexlevel => 'basic', + sub { + my ($im, $ibx) = @_; + $im->add(PublicInbox::Eml->new(<<EOF)) or BAIL_OUT; From: a\@example.com -To: $addr +To: $ibx->{-primary_address} Subject: s$i Message-ID: <a-mid-$i\@b> Date: Fri, 02 Oct 1993 00:00:00 +0000 hello world EOF + }; + my $cfgpfx = "publicinbox.test-$i"; + $cfg .= "$cfgpfx.address=$ibx->{-primary_address}\n"; + $cfg .= "$cfgpfx.inboxdir=$ibx->{inboxdir}\n"; + $cfg .= "$cfgpfx.url=http://example.com/$i\n"; - ok($im->add($mime), "added message to $i"); - $im->done; } -my $config = PublicInbox::Config->new(\$cfg); -use_ok 'PublicInbox::WWW'; -my $www = PublicInbox::WWW->new($config); +my $www = PublicInbox::WWW->new(PublicInbox::Config->new(\$cfg)); test_psgi(sub { $www->call(@_) }, sub { my ($cb) = @_; @@ -65,5 +50,4 @@ test_psgi(sub { $www->call(@_) }, sub { is($res->code, 404, "404 on $x"); } }); - -done_testing(); +done_testing;
next prev parent reply other threads:[~2021-03-15 11:58 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-15 11:57 [PATCH 00/35] memoize inbox creations Eric Wong 2021-03-15 11:57 ` [PATCH 01/35] test_common: add create_inbox helper sub Eric Wong 2021-03-15 11:57 ` [PATCH 02/35] t/lei_xsearch: use create_inbox Eric Wong 2021-03-15 11:57 ` [PATCH 03/35] test_common: minor simplifications to setup_public_inboxes Eric Wong 2021-03-15 11:57 ` [PATCH 04/35] t/imapd-tls: switch to create_inbox Eric Wong 2021-03-15 11:57 ` [PATCH 05/35] t/www_altid: use create_inbox Eric Wong 2021-03-15 11:57 ` [PATCH 06/35] t/xcpdb-reshard: " Eric Wong 2021-03-15 11:57 ` [PATCH 07/35] t/v2dupindex: create_inbox Eric Wong 2021-03-15 11:57 ` [PATCH 08/35] t/admin: switch to create_inbox Eric Wong 2021-03-15 19:51 ` [SQUASH] " Eric Wong 2021-03-15 11:58 ` [PATCH 09/35] t/html_index: remove now-worthless test Eric Wong 2021-03-15 11:58 ` [PATCH 10/35] t/plack: use create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 11/35] t/psgi_attach: convert to create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 12/35] t/httpd: " Eric Wong 2021-03-15 11:58 ` [PATCH 13/35] t/convert-compact: create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 14/35] t/altid: use create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 15/35] t/psgi_mount: switch to create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 16/35] t/feed: " Eric Wong 2021-03-15 11:58 ` [PATCH 17/35] t/psgi_bad_mids: use create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 18/35] t/psgi_multipart_not: " Eric Wong 2021-03-15 11:58 ` Eric Wong [this message] 2021-03-15 11:58 ` [PATCH 20/35] t/psgi_v2: create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 21/35] t/imapd: create_inbox (minor) Eric Wong 2021-03-15 11:58 ` [PATCH 22/35] t/solver_git: use create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 23/35] t/cgi: create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 24/35] t/edit: switch to create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 25/35] t/inbox_idle: " Eric Wong 2021-03-15 11:58 ` [PATCH 26/35] t/lei_xsearch: use create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 27/35] t/indexlevels-mirror: " Eric Wong 2021-03-15 11:58 ` [PATCH 28/35] t/multi-mid: " Eric Wong 2021-03-15 11:58 ` [PATCH 29/35] t/psgi_search: " Eric Wong 2021-03-15 11:58 ` [PATCH 30/35] t/miscsearch: " Eric Wong 2021-03-15 11:58 ` [PATCH 31/35] t/nntpd-tls: " Eric Wong 2021-03-15 11:58 ` [PATCH 32/35] t/nntpd: " Eric Wong 2021-03-15 11:58 ` [PATCH 33/35] t/thread-index-gap: create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 34/35] t/altid_v2: create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 35/35] t/*: disable fsync on tests were create_inbox isn't worth it Eric Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://public-inbox.org/README * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210315115826.17591-20-e@80x24.org \ --to=e@80x24.org \ --cc=meta@public-inbox.org \ --subject='Re: [PATCH 19/35] t/psgi_scan_all: create_inbox lots saved' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/public-inbox.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).