From: Eric Wong <e@80x24.org> To: meta@public-inbox.org Subject: [PATCH 35/35] t/*: disable fsync on tests were create_inbox isn't worth it Date: Mon, 15 Mar 2021 12:58:26 +0100 [thread overview] Message-ID: <20210315115826.17591-36-e@80x24.org> (raw) In-Reply-To: <20210315115826.17591-1-e@80x24.org> Using create_inbox doesn't seem worth the trouble, here, at the moment, but disabling fsync(2) gives a noticeable speedup on my system even with an SSD. --- t/extsearch.t | 2 ++ t/purge.t | 1 + t/replace.t | 1 + t/v1reindex.t | 1 + t/v2-add-remove-add.t | 1 + t/v2mirror.t | 1 + t/v2reindex.t | 1 + t/v2writable.t | 1 + t/watch_filter_rubylang.t | 2 ++ t/watch_maildir_v2.t | 1 + 10 files changed, 12 insertions(+) diff --git a/t/extsearch.t b/t/extsearch.t index d199fc7b..ae889ac6 100644 --- a/t/extsearch.t +++ b/t/extsearch.t @@ -236,6 +236,7 @@ if ('inject w/o indexing') { if ('reindex catches missed messages') { my $v2ibx = $cfg->lookup_name('v2test'); + $v2ibx->{-no_fsync} = 1; my $im = PublicInbox::InboxWritable->new($v2ibx)->importer(0); my $cmt_a = $v2ibx->mm->last_commit_xap($schema_version, 0); my $eml = eml_load('t/data/0001.patch'); @@ -296,6 +297,7 @@ if ('reindex catches missed messages') { if ('reindex catches content bifurcation') { use PublicInbox::MID qw(mids); my $v2ibx = $cfg->lookup_name('v2test'); + $v2ibx->{-no_fsync} = 1; my $im = PublicInbox::InboxWritable->new($v2ibx)->importer(0); my $eml = eml_load('t/data/message_embed.eml'); my $cmt_a = $v2ibx->mm->last_commit_xap($schema_version, 0); diff --git a/t/purge.t b/t/purge.t index f4281c13..a33cd329 100644 --- a/t/purge.t +++ b/t/purge.t @@ -16,6 +16,7 @@ my $ibx = PublicInbox::Inbox->new({ inboxdir => $inboxdir, name => 'test-v2purge', version => 2, + -no_fsync => 1, -primary_address => 'test@example.com', indexlevel => 'basic', }); diff --git a/t/replace.t b/t/replace.t index 51bdb964..626cbe9b 100644 --- a/t/replace.t +++ b/t/replace.t @@ -20,6 +20,7 @@ sub test_replace ($$$) { inboxdir => "$tmpdir/testbox", name => $this, version => $v, + -no_fsync => 1, -primary_address => 'test@example.com', indexlevel => $level, }); diff --git a/t/v1reindex.t b/t/v1reindex.t index 36cefda5..f593b323 100644 --- a/t/v1reindex.t +++ b/t/v1reindex.t @@ -18,6 +18,7 @@ my $ibx_config = { name => 'test-v1reindex', -primary_address => 'test@example.com', indexlevel => 'full', + -no_fsync => 1, }; my $mime = PublicInbox::Eml->new(<<'EOF'); From: a@example.com diff --git a/t/v2-add-remove-add.t b/t/v2-add-remove-add.t index b325e521..579cdcb6 100644 --- a/t/v2-add-remove-add.t +++ b/t/v2-add-remove-add.t @@ -13,6 +13,7 @@ my $ibx = { inboxdir => "$inboxdir/v2", name => 'test-v2writable', version => 2, + -no_fsync => 1, -primary_address => 'test@example.com', }; $ibx = PublicInbox::Inbox->new($ibx); diff --git a/t/v2mirror.t b/t/v2mirror.t index 12e3fcd0..012e5bd2 100644 --- a/t/v2mirror.t +++ b/t/v2mirror.t @@ -36,6 +36,7 @@ my $cfg = PublicInbox::Config->new($pi_config); my $ibx = $cfg->lookup('test@example.com'); ok($ibx, 'inbox found'); $ibx->{version} = 2; +$ibx->{-no_fsync} = 1; my $v2w = PublicInbox::V2Writable->new($ibx, 1); ok $v2w, 'v2w loaded'; $v2w->{parallel} = 0; diff --git a/t/v2reindex.t b/t/v2reindex.t index a931225c..1145e31b 100644 --- a/t/v2reindex.t +++ b/t/v2reindex.t @@ -18,6 +18,7 @@ my $ibx_config = { version => 2, -primary_address => 'test@example.com', indexlevel => 'full', + -no_fsync => 1, }; my $agpl = do { open my $fh, '<', 'COPYING' or die "can't open COPYING: $!"; diff --git a/t/v2writable.t b/t/v2writable.t index f0fa8a79..d9e7b980 100644 --- a/t/v2writable.t +++ b/t/v2writable.t @@ -17,6 +17,7 @@ my $ibx = { inboxdir => $inboxdir, name => 'test-v2writable', version => 2, + -no_fsync => 1, -primary_address => 'test@example.com', }; $ibx = PublicInbox::Inbox->new($ibx); diff --git a/t/watch_filter_rubylang.t b/t/watch_filter_rubylang.t index 29a9f793..5deb2082 100644 --- a/t/watch_filter_rubylang.t +++ b/t/watch_filter_rubylang.t @@ -74,6 +74,7 @@ publicinboxwatch.watchspam=maildir:$spamdir EOF my $cfg = PublicInbox::Config->new(\$orig); my $ibx = $cfg->lookup_name($v); + $ibx->{-no_fsync} = 1; ok($ibx, 'found inbox by name'); my $w = PublicInbox::Watch->new($cfg); @@ -103,6 +104,7 @@ EOF $cfg = PublicInbox::Config->new(\$orig); $ibx = $cfg->lookup_name($v); + $ibx->{-no_fsync} = 1; is($ibx->search->reopen->mset('b:spam')->size, 0, 'spam removed'); is_deeply([], \@warn, 'no warnings'); diff --git a/t/watch_maildir_v2.t b/t/watch_maildir_v2.t index 195e238b..7b46232b 100644 --- a/t/watch_maildir_v2.t +++ b/t/watch_maildir_v2.t @@ -47,6 +47,7 @@ EOF my $cfg = PublicInbox::Config->new(\$orig); my $ibx = $cfg->lookup_name('test'); ok($ibx, 'found inbox by name'); +$ibx->{-no_fsync} = 1; PublicInbox::Watch->new($cfg)->scan('full'); my $total = scalar @{$ibx->over->recent};
prev parent reply other threads:[~2021-03-15 11:58 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-15 11:57 [PATCH 00/35] memoize inbox creations Eric Wong 2021-03-15 11:57 ` [PATCH 01/35] test_common: add create_inbox helper sub Eric Wong 2021-03-15 11:57 ` [PATCH 02/35] t/lei_xsearch: use create_inbox Eric Wong 2021-03-15 11:57 ` [PATCH 03/35] test_common: minor simplifications to setup_public_inboxes Eric Wong 2021-03-15 11:57 ` [PATCH 04/35] t/imapd-tls: switch to create_inbox Eric Wong 2021-03-15 11:57 ` [PATCH 05/35] t/www_altid: use create_inbox Eric Wong 2021-03-15 11:57 ` [PATCH 06/35] t/xcpdb-reshard: " Eric Wong 2021-03-15 11:57 ` [PATCH 07/35] t/v2dupindex: create_inbox Eric Wong 2021-03-15 11:57 ` [PATCH 08/35] t/admin: switch to create_inbox Eric Wong 2021-03-15 19:51 ` [SQUASH] " Eric Wong 2021-03-15 11:58 ` [PATCH 09/35] t/html_index: remove now-worthless test Eric Wong 2021-03-15 11:58 ` [PATCH 10/35] t/plack: use create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 11/35] t/psgi_attach: convert to create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 12/35] t/httpd: " Eric Wong 2021-03-15 11:58 ` [PATCH 13/35] t/convert-compact: create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 14/35] t/altid: use create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 15/35] t/psgi_mount: switch to create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 16/35] t/feed: " Eric Wong 2021-03-15 11:58 ` [PATCH 17/35] t/psgi_bad_mids: use create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 18/35] t/psgi_multipart_not: " Eric Wong 2021-03-15 11:58 ` [PATCH 19/35] t/psgi_scan_all: create_inbox lots saved Eric Wong 2021-03-15 11:58 ` [PATCH 20/35] t/psgi_v2: create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 21/35] t/imapd: create_inbox (minor) Eric Wong 2021-03-15 11:58 ` [PATCH 22/35] t/solver_git: use create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 23/35] t/cgi: create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 24/35] t/edit: switch to create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 25/35] t/inbox_idle: " Eric Wong 2021-03-15 11:58 ` [PATCH 26/35] t/lei_xsearch: use create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 27/35] t/indexlevels-mirror: " Eric Wong 2021-03-15 11:58 ` [PATCH 28/35] t/multi-mid: " Eric Wong 2021-03-15 11:58 ` [PATCH 29/35] t/psgi_search: " Eric Wong 2021-03-15 11:58 ` [PATCH 30/35] t/miscsearch: " Eric Wong 2021-03-15 11:58 ` [PATCH 31/35] t/nntpd-tls: " Eric Wong 2021-03-15 11:58 ` [PATCH 32/35] t/nntpd: " Eric Wong 2021-03-15 11:58 ` [PATCH 33/35] t/thread-index-gap: create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 34/35] t/altid_v2: create_inbox Eric Wong 2021-03-15 11:58 ` Eric Wong [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://public-inbox.org/README * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210315115826.17591-36-e@80x24.org \ --to=e@80x24.org \ --cc=meta@public-inbox.org \ --subject='Re: [PATCH 35/35] t/*: disable fsync on tests were create_inbox isn'\''t worth it' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/public-inbox.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).