user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 00/35] memoize inbox creations
Date: Mon, 15 Mar 2021 12:57:51 +0100	[thread overview]
Message-ID: <20210315115826.17591-1-e@80x24.org> (raw)

This speeds up a bunch of tests by a few dozen to hundreds of
milliseconds.  Part of it is due to disabling fsync/fdatasync in
a few more places.

Users with slower TMPDIR will notice more, and users with TMPDIR
pointed to tmpfs will notice it least.

Overall it's not hugely significant, but the diffstat
and LoC reduction still makes it nice even if there were
no performance improvements.

Eric Wong (35):
  test_common: add create_inbox helper sub
  t/lei_xsearch: use create_inbox
  test_common: minor simplifications to setup_public_inboxes
  t/imapd-tls: switch to create_inbox
  t/www_altid: use create_inbox
  t/xcpdb-reshard: use create_inbox
  t/v2dupindex: create_inbox
  t/admin: switch to create_inbox
  t/html_index: remove now-worthless test
  t/plack: use create_inbox
  t/psgi_attach: convert to create_inbox
  t/httpd: convert to create_inbox
  t/convert-compact: create_inbox
  t/altid: use create_inbox
  t/psgi_mount: switch to create_inbox
  t/feed: switch to create_inbox
  t/psgi_bad_mids: use create_inbox
  t/psgi_multipart_not: use create_inbox
  t/psgi_scan_all: create_inbox lots saved
  t/psgi_v2: create_inbox
  t/imapd: create_inbox (minor)
  t/solver_git: use create_inbox
  t/cgi: create_inbox
  t/edit: switch to create_inbox
  t/inbox_idle: switch to create_inbox
  t/lei_xsearch: use create_inbox
  t/indexlevels-mirror: use create_inbox
  t/multi-mid: use create_inbox
  t/psgi_search: use create_inbox
  t/miscsearch: use create_inbox
  t/nntpd-tls: use create_inbox
  t/nntpd: use create_inbox
  t/thread-index-gap: create_inbox
  t/altid_v2: create_inbox
  t/*: disable fsync on tests were create_inbox isn't worth it

 MANIFEST                      |   2 +-
 Makefile.PL                   |   3 +-
 lib/PublicInbox/TestCommon.pm |  67 ++++++++++++++---
 t/admin.t                     |  38 ++++------
 t/altid.t                     |  26 ++-----
 t/altid_v2.t                  |  48 +++++-------
 t/cgi.t                       |  84 +++++++++------------
 t/convert-compact.t           |  48 +++++-------
 t/data-gen/.gitignore         |   2 +
 t/edit.t                      |  34 ++++-----
 t/extsearch.t                 |   2 +
 t/feed.t                      |  53 ++++----------
 t/html_index.t                |  56 --------------
 t/httpd.t                     |  36 +++------
 t/imapd-tls.t                 |  38 +++-------
 t/imapd.t                     |  66 ++++++++---------
 t/inbox_idle.t                |  31 ++++----
 t/indexlevels-mirror.t        |  24 +++---
 t/lei-q-remote-import.t       |  20 ++---
 t/lei_xsearch.t               |  56 +++++---------
 t/miscsearch.t                |  28 +++----
 t/multi-mid.t                 |  34 +++------
 t/nntpd-tls.t                 |  52 ++++---------
 t/nntpd.t                     | 102 ++++++++++++--------------
 t/plack.t                     |  69 +++++++----------
 t/psgi_attach.t               |  56 ++++++--------
 t/psgi_bad_mids.t             |  46 ++++--------
 t/psgi_mount.t                |  35 ++++-----
 t/psgi_multipart_not.t        |  35 +++------
 t/psgi_scan_all.t             |  48 ++++--------
 t/psgi_search.t               |  37 +++-------
 t/psgi_v2.t                   | 134 ++++++++++++++++------------------
 t/purge.t                     |   1 +
 t/replace.t                   |   1 +
 t/solver_git.t                |  88 +++++++++++-----------
 t/thread-index-gap.t          |  24 +++---
 t/v1reindex.t                 |   1 +
 t/v2-add-remove-add.t         |   1 +
 t/v2dupindex.t                |  76 +++++++++----------
 t/v2mirror.t                  |   1 +
 t/v2reindex.t                 |   1 +
 t/v2writable.t                |   1 +
 t/watch_filter_rubylang.t     |   2 +
 t/watch_maildir_v2.t          |   1 +
 t/www_altid.t                 |  47 +++++-------
 t/xcpdb-reshard.t             |  54 ++++++--------
 46 files changed, 692 insertions(+), 1017 deletions(-)
 create mode 100644 t/data-gen/.gitignore
 delete mode 100644 t/html_index.t

             reply	other threads:[~2021-03-15 11:58 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-15 11:57 Eric Wong [this message]
2021-03-15 11:57 ` [PATCH 01/35] test_common: add create_inbox helper sub Eric Wong
2021-03-15 11:57 ` [PATCH 02/35] t/lei_xsearch: use create_inbox Eric Wong
2021-03-15 11:57 ` [PATCH 03/35] test_common: minor simplifications to setup_public_inboxes Eric Wong
2021-03-15 11:57 ` [PATCH 04/35] t/imapd-tls: switch to create_inbox Eric Wong
2021-03-15 11:57 ` [PATCH 05/35] t/www_altid: use create_inbox Eric Wong
2021-03-15 11:57 ` [PATCH 06/35] t/xcpdb-reshard: " Eric Wong
2021-03-15 11:57 ` [PATCH 07/35] t/v2dupindex: create_inbox Eric Wong
2021-03-15 11:57 ` [PATCH 08/35] t/admin: switch to create_inbox Eric Wong
2021-03-15 19:51   ` [SQUASH] " Eric Wong
2021-03-15 11:58 ` [PATCH 09/35] t/html_index: remove now-worthless test Eric Wong
2021-03-15 11:58 ` [PATCH 10/35] t/plack: use create_inbox Eric Wong
2021-03-15 11:58 ` [PATCH 11/35] t/psgi_attach: convert to create_inbox Eric Wong
2021-03-15 11:58 ` [PATCH 12/35] t/httpd: " Eric Wong
2021-03-15 11:58 ` [PATCH 13/35] t/convert-compact: create_inbox Eric Wong
2021-03-15 11:58 ` [PATCH 14/35] t/altid: use create_inbox Eric Wong
2021-03-15 11:58 ` [PATCH 15/35] t/psgi_mount: switch to create_inbox Eric Wong
2021-03-15 11:58 ` [PATCH 16/35] t/feed: " Eric Wong
2021-03-15 11:58 ` [PATCH 17/35] t/psgi_bad_mids: use create_inbox Eric Wong
2021-03-15 11:58 ` [PATCH 18/35] t/psgi_multipart_not: " Eric Wong
2021-03-15 11:58 ` [PATCH 19/35] t/psgi_scan_all: create_inbox lots saved Eric Wong
2021-03-15 11:58 ` [PATCH 20/35] t/psgi_v2: create_inbox Eric Wong
2021-03-15 11:58 ` [PATCH 21/35] t/imapd: create_inbox (minor) Eric Wong
2021-03-15 11:58 ` [PATCH 22/35] t/solver_git: use create_inbox Eric Wong
2021-03-15 11:58 ` [PATCH 23/35] t/cgi: create_inbox Eric Wong
2021-03-15 11:58 ` [PATCH 24/35] t/edit: switch to create_inbox Eric Wong
2021-03-15 11:58 ` [PATCH 25/35] t/inbox_idle: " Eric Wong
2021-03-15 11:58 ` [PATCH 26/35] t/lei_xsearch: use create_inbox Eric Wong
2021-03-15 11:58 ` [PATCH 27/35] t/indexlevels-mirror: " Eric Wong
2021-03-15 11:58 ` [PATCH 28/35] t/multi-mid: " Eric Wong
2021-03-15 11:58 ` [PATCH 29/35] t/psgi_search: " Eric Wong
2021-03-15 11:58 ` [PATCH 30/35] t/miscsearch: " Eric Wong
2021-03-15 11:58 ` [PATCH 31/35] t/nntpd-tls: " Eric Wong
2021-03-15 11:58 ` [PATCH 32/35] t/nntpd: " Eric Wong
2021-03-15 11:58 ` [PATCH 33/35] t/thread-index-gap: create_inbox Eric Wong
2021-03-15 11:58 ` [PATCH 34/35] t/altid_v2: create_inbox Eric Wong
2021-03-15 11:58 ` [PATCH 35/35] t/*: disable fsync on tests were create_inbox isn't worth it Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210315115826.17591-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    --subject='Re: [PATCH 00/35] memoize inbox creations' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

user/dev discussion of public-inbox itself

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 meta meta/ https://public-inbox.org/meta \
		meta@public-inbox.org
	public-inbox-index meta

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://7fh6tueqddpjyxjmgtdiueylzoqt6pt7hec3pukyptlmohoowvhde4yd.onion/inbox.comp.mail.public-inbox.meta
	nntp://ie5yzdi7fg72h7s4sdcztq5evakq23rdt33mfyfcddc5u3ndnw24ogqd.onion/inbox.comp.mail.public-inbox.meta
	nntp://4uok3hntl7oi7b4uf4rtfwefqeexfzil2w6kgk2jn5z2f764irre7byd.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.io/gmane.mail.public-inbox.general
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git