From: Eric Wong <e@80x24.org> To: meta@public-inbox.org Subject: [PATCH 17/35] t/psgi_bad_mids: use create_inbox Date: Mon, 15 Mar 2021 12:58:08 +0100 [thread overview] Message-ID: <20210315115826.17591-18-e@80x24.org> (raw) In-Reply-To: <20210315115826.17591-1-e@80x24.org> Over 100ms saved and it's less code to boot. --- t/psgi_bad_mids.t | 46 +++++++++++++++------------------------------- 1 file changed, 15 insertions(+), 31 deletions(-) diff --git a/t/psgi_bad_mids.t b/t/psgi_bad_mids.t index f23680f8..f92e4f97 100644 --- a/t/psgi_bad_mids.t +++ b/t/psgi_bad_mids.t @@ -1,31 +1,17 @@ +#!perl -w # Copyright (C) 2018-2021 all contributors <meta@public-inbox.org> # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt> use strict; -use warnings; -use Test::More; +use v5.10.1; +use PublicInbox::TestCommon; use PublicInbox::Eml; use PublicInbox::Config; -use PublicInbox::TestCommon; my @mods = qw(DBD::SQLite HTTP::Request::Common Plack::Test - URI::Escape Plack::Builder PublicInbox::WWW); + URI::Escape Plack::Builder); require_git 2.6; require_mods(@mods); use_ok($_) for @mods; use_ok 'PublicInbox::WWW'; -use_ok 'PublicInbox::V2Writable'; -my ($inboxdir, $for_destroy) = tmpdir(); -my $cfgpfx = "publicinbox.bad-mids"; -my $ibx = { - inboxdir => $inboxdir, - name => 'bad-mids', - version => 2, - -primary_address => 'test@example.com', - indexlevel => 'basic', -}; -$ibx = PublicInbox::Inbox->new($ibx); -my $im = PublicInbox::V2Writable->new($ibx, 1); -$im->{parallel} = 0; - my $msgs = <<''; F1V5OR6NMF.3M649JTLO9IXD@tux.localdomain/hehe1"'<foo F1V5NB0PTU.3U0DCVGAJ750Z@tux.localdomain"'<>/foo @@ -36,25 +22,25 @@ F1V58X3CMU.2DCCVAKQZGADV@tux.localdomain/../../../../foo F1TVKINT3G.2S6I36MXMHYG6@tux.localdomain" onclick="alert(1)" my @mids = split(/\n/, $msgs); -my $i = 0; -foreach my $mid (@mids) { - my $data = << ""; +my $ibx = create_inbox 'bad-mids', version => 2, indexlevel => 'basic', sub { + my ($im) = @_; + my $i = 0; + for my $mid (@mids) { + $im->add(PublicInbox::Eml->new(<<"")) or BAIL_OUT; Subject: test Message-ID: <$mid> From: a\@example.com To: b\@example.com Date: Fri, 02 Oct 1993 00:00:0$i +0000 + $i++; + } +}; - my $mime = PublicInbox::Eml->new(\$data); - ok($im->add($mime), "added $mid"); - $i++ -} -$im->done; - +my $cfgpfx = "publicinbox.bad-mids"; my $cfg = <<EOF; $cfgpfx.address=$ibx->{-primary_address} -$cfgpfx.inboxdir=$inboxdir +$cfgpfx.inboxdir=$ibx->{inboxdir} EOF my $config = PublicInbox::Config->new(\$cfg); my $www = PublicInbox::WWW->new($config); @@ -84,6 +70,4 @@ test_psgi(sub { $www->call(@_) }, sub { } }); -done_testing(); - -1; +done_testing;
next prev parent reply other threads:[~2021-03-15 11:58 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-15 11:57 [PATCH 00/35] memoize inbox creations Eric Wong 2021-03-15 11:57 ` [PATCH 01/35] test_common: add create_inbox helper sub Eric Wong 2021-03-15 11:57 ` [PATCH 02/35] t/lei_xsearch: use create_inbox Eric Wong 2021-03-15 11:57 ` [PATCH 03/35] test_common: minor simplifications to setup_public_inboxes Eric Wong 2021-03-15 11:57 ` [PATCH 04/35] t/imapd-tls: switch to create_inbox Eric Wong 2021-03-15 11:57 ` [PATCH 05/35] t/www_altid: use create_inbox Eric Wong 2021-03-15 11:57 ` [PATCH 06/35] t/xcpdb-reshard: " Eric Wong 2021-03-15 11:57 ` [PATCH 07/35] t/v2dupindex: create_inbox Eric Wong 2021-03-15 11:57 ` [PATCH 08/35] t/admin: switch to create_inbox Eric Wong 2021-03-15 19:51 ` [SQUASH] " Eric Wong 2021-03-15 11:58 ` [PATCH 09/35] t/html_index: remove now-worthless test Eric Wong 2021-03-15 11:58 ` [PATCH 10/35] t/plack: use create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 11/35] t/psgi_attach: convert to create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 12/35] t/httpd: " Eric Wong 2021-03-15 11:58 ` [PATCH 13/35] t/convert-compact: create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 14/35] t/altid: use create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 15/35] t/psgi_mount: switch to create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 16/35] t/feed: " Eric Wong 2021-03-15 11:58 ` Eric Wong [this message] 2021-03-15 11:58 ` [PATCH 18/35] t/psgi_multipart_not: use create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 19/35] t/psgi_scan_all: create_inbox lots saved Eric Wong 2021-03-15 11:58 ` [PATCH 20/35] t/psgi_v2: create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 21/35] t/imapd: create_inbox (minor) Eric Wong 2021-03-15 11:58 ` [PATCH 22/35] t/solver_git: use create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 23/35] t/cgi: create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 24/35] t/edit: switch to create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 25/35] t/inbox_idle: " Eric Wong 2021-03-15 11:58 ` [PATCH 26/35] t/lei_xsearch: use create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 27/35] t/indexlevels-mirror: " Eric Wong 2021-03-15 11:58 ` [PATCH 28/35] t/multi-mid: " Eric Wong 2021-03-15 11:58 ` [PATCH 29/35] t/psgi_search: " Eric Wong 2021-03-15 11:58 ` [PATCH 30/35] t/miscsearch: " Eric Wong 2021-03-15 11:58 ` [PATCH 31/35] t/nntpd-tls: " Eric Wong 2021-03-15 11:58 ` [PATCH 32/35] t/nntpd: " Eric Wong 2021-03-15 11:58 ` [PATCH 33/35] t/thread-index-gap: create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 34/35] t/altid_v2: create_inbox Eric Wong 2021-03-15 11:58 ` [PATCH 35/35] t/*: disable fsync on tests were create_inbox isn't worth it Eric Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://public-inbox.org/README * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210315115826.17591-18-e@80x24.org \ --to=e@80x24.org \ --cc=meta@public-inbox.org \ --subject='Re: [PATCH 17/35] t/psgi_bad_mids: use create_inbox' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/public-inbox.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).