From: Luca Boccassi via Libc-alpha <libc-alpha@sourceware.org>
To: Mark Wielaard <mark@klomp.org>, libc-alpha@sourceware.org
Subject: Re: [PATCH] elf: add definition for FDO_PACKAGING_METADATA note
Date: Fri, 26 Nov 2021 17:01:59 +0000 [thread overview]
Message-ID: <e2b19384b113a9f3fb2c2cf31d0f69ba9172677c.camel@gmail.com> (raw)
In-Reply-To: <27f914bcc00e9fc208cfce9b94c6d513b10535e2.camel@klomp.org>
[-- Attachment #1: Type: text/plain, Size: 1387 bytes --]
On Fri, 2021-11-26 at 17:49 +0100, Mark Wielaard wrote:
> Hi Luca,
>
> On Sun, 2021-11-21 at 19:39 +0000, luca.boccassi@gmail.com wrote:
> > From: Luca Boccassi <bluca@debian.org>
> >
> > As defined on: https://systemd.io/COREDUMP_PACKAGE_METADATA/
> > this note will be used starting from Fedora 36.
> >
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > ---
> > As requested by Mark on:
> > https://sourceware.org/pipermail/elfutils-devel/2021q4/004387.html
> >
> > elf/elf.h | 3 +++
> > 1 file changed, 3 insertions(+)
>
> Two small nitpicks.
>
> > diff --git a/elf/elf.h b/elf/elf.h
> > index 50f87bac..4bb390b2 100644
> > --- a/elf/elf.h
> > +++ b/elf/elf.h
> > @@ -1302,6 +1302,9 @@ typedef struct
> > /* Program property. */
> > #define NT_GNU_PROPERTY_TYPE_0 5
> >
> >
> > +/* Packaging metadata as defined on https://systemd.io/COREDUMP_PACKAGE_METADATA/ */
>
> This comment is a little too wide.
>
> > +#define FDO_PACKAGING_METADATA 0xcafe1a7e
>
> This doesn't follow the naming scheme of the other note types. Could we
> use NT_FDO_PACKAGING_METADATA?
>
> > /* Note section name of program property. */
> > #define NOTE_GNU_PROPERTY_SECTION_NAME ".note.gnu.property"
>
> Reformatted patch attached.
>
> Thanks,
>
> Mark
Thank you, sent v2 as suggested.
--
Kind regards,
Luca Boccassi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-11-26 17:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-21 19:39 [PATCH] elf: add definition for FDO_PACKAGING_METADATA note luca.boccassi--- via Libc-alpha
2021-11-22 14:03 ` Florian Weimer via Libc-alpha
2021-11-22 14:44 ` Luca Boccassi via Libc-alpha
2021-11-22 15:17 ` Florian Weimer via Libc-alpha
2021-11-23 9:42 ` Mark Wielaard
2021-11-26 16:49 ` Mark Wielaard
2021-11-26 17:01 ` Luca Boccassi via Libc-alpha [this message]
2021-11-26 17:01 ` [PATCH v2] elf: add definition for NT_FDO_PACKAGING_METADATA note luca.boccassi--- via Libc-alpha
2021-11-26 20:27 ` Florian Weimer via Libc-alpha
2021-11-26 20:59 ` Luca Boccassi via Libc-alpha
2021-11-26 20:58 ` [PATCH v3] elf: add definition for ELF_NOTE_FDO and " luca.boccassi--- via Libc-alpha
2021-11-29 20:35 ` Florian Weimer via Libc-alpha
2021-12-02 22:02 ` Florian Weimer via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2b19384b113a9f3fb2c2cf31d0f69ba9172677c.camel@gmail.com \
--to=libc-alpha@sourceware.org \
--cc=luca.boccassi@gmail.com \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).