From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 34C3E1F953 for ; Fri, 26 Nov 2021 17:02:37 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E486B3857C5F for ; Fri, 26 Nov 2021 17:02:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E486B3857C5F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637946155; bh=kFIx7tcyOZNVJ3fcQDcgECa7M6f+OZ1bqhos6AvvEhk=; h=Subject:To:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=CzBJFl5Q0jD1CjuSE959Yef2KiJhSs4wU758STctbFU7x223UgaZdSPultSeTS1Oo aizYkttMpoCQ+UakNSONuIMExOg6msKWn3CzGZMIOdE6XSpE/O3evMDoexyAd/81oz 4O51DKDIC+aMNRBsFPF4s/qUOxyLDMKn5MNX6OIM= Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id 901B23857C4B for ; Fri, 26 Nov 2021 17:02:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 901B23857C4B Received: by mail-wr1-x430.google.com with SMTP id i5so20000208wrb.2 for ; Fri, 26 Nov 2021 09:02:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version; bh=kFIx7tcyOZNVJ3fcQDcgECa7M6f+OZ1bqhos6AvvEhk=; b=D+fK3V8S6eluU5B0RHpUjTdlW8RKMD9sBvckRHnRqLd4otGhDixZgSzVjGqyvRDhWK 5+xng/LqUHTIowuiUlmI3oBm5oeM+IkyOiPon2LxXj3n0kMAhc1DfweapARujnTxaG6/ xTCumEEkBgaq/ncuYoqNwUj0Bf1kGAdldFc2TyyJM+AURI3fbhzu3y6+xHpL4/SI4m9G e4Q/EBoE96L+N7xFdGll57sH9THjfCcqPZAW3Gya/8utASAoT3jphvjf2ikDUSjqlyf/ PSA8r88PePOfkDbfg9Gd+h3ZOHckVKVxoLoxnshn61X4yYUW2pLbS7Eh/tW5keRXi0Zt nDQQ== X-Gm-Message-State: AOAM533JrPaZt6GhCfPeM6uJwmSFU/60pcA7LajHB22CJE2fXNUC4kAY CDglh/ee49JfDF98BA4Zh0DSRRbKcwMKNw== X-Google-Smtp-Source: ABdhPJx7zVHnjEFvUadD2lzP30EkJgG/doZWk/38EJua0Oy8O9DE8uAQB60dodEbHgUL9iSVrsIHCw== X-Received: by 2002:adf:f7c2:: with SMTP id a2mr14744591wrq.71.1637946121678; Fri, 26 Nov 2021 09:02:01 -0800 (PST) Received: from [192.168.1.112] ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id r83sm11569374wma.22.2021.11.26.09.02.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Nov 2021 09:02:01 -0800 (PST) Message-ID: Subject: Re: [PATCH] elf: add definition for FDO_PACKAGING_METADATA note To: Mark Wielaard , libc-alpha@sourceware.org Date: Fri, 26 Nov 2021 17:01:59 +0000 In-Reply-To: <27f914bcc00e9fc208cfce9b94c6d513b10535e2.camel@klomp.org> References: <20211121193939.105186-1-luca.boccassi@gmail.com> <27f914bcc00e9fc208cfce9b94c6d513b10535e2.camel@klomp.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-pbv4BVA9Q4GAm/nt9TXc" User-Agent: Evolution 3.38.3-1+plugin MIME-Version: 1.0 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luca Boccassi via Libc-alpha Reply-To: Luca Boccassi Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" --=-pbv4BVA9Q4GAm/nt9TXc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2021-11-26 at 17:49 +0100, Mark Wielaard wrote: > Hi Luca, >=20 > On Sun, 2021-11-21 at 19:39 +0000, luca.boccassi@gmail.com wrote: > > From: Luca Boccassi > >=20 > > As defined on: https://systemd.io/COREDUMP_PACKAGE_METADATA/ > > this note will be used starting from Fedora 36. > >=20 > > Signed-off-by: Luca Boccassi > > --- > > As requested by Mark on: > > https://sourceware.org/pipermail/elfutils-devel/2021q4/004387.html > >=20 > > =C2=A0elf/elf.h | 3 +++ > > =C2=A01 file changed, 3 insertions(+) >=20 > Two small nitpicks. >=20 > > diff --git a/elf/elf.h b/elf/elf.h > > index 50f87bac..4bb390b2 100644 > > --- a/elf/elf.h > > +++ b/elf/elf.h > > @@ -1302,6 +1302,9 @@ typedef struct > > =C2=A0/* Program property. */ > > =C2=A0#define NT_GNU_PROPERTY_TYPE_0 5 > > =C2=A0 > >=20 > > +/* Packaging metadata as defined on https://systemd.io/COREDUMP_PACKAG= E_METADATA/ */ >=20 > This comment is a little too wide. >=20 > > +#define FDO_PACKAGING_METADATA 0xcafe1a7e >=20 > This doesn't follow the naming scheme of the other note types. Could we > use NT_FDO_PACKAGING_METADATA? >=20 > > =C2=A0/* Note section name of program property. */ > > =C2=A0#define NOTE_GNU_PROPERTY_SECTION_NAME ".note.gnu.property" >=20 > Reformatted patch attached. >=20 > Thanks, >=20 > Mark Thank you, sent v2 as suggested. --=20 Kind regards, Luca Boccassi --=-pbv4BVA9Q4GAm/nt9TXc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEErCSqx93EIPGOymuRKGv37813JB4FAmGhEwcACgkQKGv37813 JB7VzA//ToVVhO04QP6dfoFHNEuICbrOZTz291ywu2yNjHlXANrrQEChGZ8+xr42 TvWGvgRt1dGUyvA1dGvrPczkqcAu9TPi2Zxi7NADv/nYpTPVcz6v1IPDXLFm/2h3 7e8SgfI0YUi0Cwo7imlcKDwEdXEprzXRePtGNMP1C6IM2TqbO8lLlb9AgefhCODy XMG+A/1Sv0Ge3fB1XaPw/AXTSPjW/G5UdnWqWqcEVdNabxcCBfNjnX+xffiGcFbR Es8ia/drZ76T+DA/Fe61GzHNy8JOMiL3LZgpgXDUI/G5QA5g/dnw8Io8bWVe+Dr0 oQexfUFCG3nMwC4xBPGyuV+l8CIFcA16JMsdtb4kCfOPiziVbbhPy4FkDPMBfyOW mqhxKbDGSfdhJCU9Zk9l10LTk7Dn/0SgIZcb7/HGqSOpNqKgd8K0zsr9BfVYPObW NSHwNcPNAGKbvxV0R0dUTPsdjGqbfSpfbnERme6zsEi2/D2KWohgdcEJbJuxfEqg V8QyRr3ZgiLZIlYqB6hd6zjfNglChom61RFjl+SnAwd9PZ1a64flEPF5Ux+8TfOu 3rjC+e5OuWcDhdEzT8pR49rQfa9VBgq2RzGZSUvz+zyTrqtOYNZ75xNpaR92WX+d 9ePUScZzTo9AIoe/OJcjqyueHe/zqcgwe0s5JwfZEkmEBbWDPs0= =2gsl -----END PGP SIGNATURE----- --=-pbv4BVA9Q4GAm/nt9TXc--