Re: [PATCH] elf: add definition for FDO_PACKAGING_METADATA note

[Mark Wielaard <mark@klomp.org>]

[-- Attachment #1: Type: text/plain, Size: 1160 bytes --]

Hi Luca,

On Sun, 2021-11-21 at 19:39 +0000, luca.boccassi@gmail.com wrote:
> From: Luca Boccassi <bluca@debian.org>
> 
> As defined on: https://systemd.io/COREDUMP_PACKAGE_METADATA/
> this note will be used starting from Fedora 36.
> 
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
> As requested by Mark on:
> https://sourceware.org/pipermail/elfutils-devel/2021q4/004387.html
> 
>  elf/elf.h | 3 +++
>  1 file changed, 3 insertions(+)

Two small nitpicks.

> diff --git a/elf/elf.h b/elf/elf.h
> index 50f87bac..4bb390b2 100644
> --- a/elf/elf.h
> +++ b/elf/elf.h
> @@ -1302,6 +1302,9 @@ typedef struct
>  /* Program property.  */
>  #define NT_GNU_PROPERTY_TYPE_0 5
>  
> +/* Packaging metadata as defined on https://systemd.io/COREDUMP_PACKAGE_METADATA/ */

This comment is a little too wide.

> +#define FDO_PACKAGING_METADATA 0xcafe1a7e

This doesn't follow the naming scheme of the other note types. Could we
use NT_FDO_PACKAGING_METADATA?

>  /* Note section name of program property.   */
>  #define NOTE_GNU_PROPERTY_SECTION_NAME ".note.gnu.property"

Reformatted patch attached.

Thanks,

Mark


[-- Attachment #2: 0001-elf-add-definition-for-NT_FDO_PACKAGING_METADATA-not.patch --]
[-- Type: text/x-patch, Size: 901 bytes --]

From 8677485d565d820cbb5f931e1b319b4f4578ad19 Mon Sep 17 00:00:00 2001
From: Luca Boccassi <bluca@debian.org>
Date: Sun, 21 Nov 2021 19:39:39 +0000
Subject: [PATCH] elf: add definition for NT_FDO_PACKAGING_METADATA note

As defined on: https://systemd.io/COREDUMP_PACKAGE_METADATA/
this note will be used starting from Fedora 36.

Signed-off-by: Luca Boccassi <bluca@debian.org>
---
 elf/elf.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/elf/elf.h b/elf/elf.h
index 50f87baceb..f2b72bd9f5 100644
--- a/elf/elf.h
+++ b/elf/elf.h
@@ -1302,6 +1302,10 @@ typedef struct
 /* Program property.  */
 #define NT_GNU_PROPERTY_TYPE_0 5
 
+/* Packaging metadata as defined on
+   https://systemd.io/COREDUMP_PACKAGE_METADATA/ */
+#define NT_FDO_PACKAGING_METADATA 0xcafe1a7e
+
 /* Note section name of program property.   */
 #define NOTE_GNU_PROPERTY_SECTION_NAME ".note.gnu.property"
 
-- 
2.18.4