Hi Luca, On Sun, 2021-11-21 at 19:39 +0000, luca.boccassi@gmail.com wrote: > From: Luca Boccassi > > As defined on: https://systemd.io/COREDUMP_PACKAGE_METADATA/ > this note will be used starting from Fedora 36. > > Signed-off-by: Luca Boccassi > --- > As requested by Mark on: > https://sourceware.org/pipermail/elfutils-devel/2021q4/004387.html > > elf/elf.h | 3 +++ > 1 file changed, 3 insertions(+) Two small nitpicks. > diff --git a/elf/elf.h b/elf/elf.h > index 50f87bac..4bb390b2 100644 > --- a/elf/elf.h > +++ b/elf/elf.h > @@ -1302,6 +1302,9 @@ typedef struct > /* Program property. */ > #define NT_GNU_PROPERTY_TYPE_0 5 > > +/* Packaging metadata as defined on https://systemd.io/COREDUMP_PACKAGE_METADATA/ */ This comment is a little too wide. > +#define FDO_PACKAGING_METADATA 0xcafe1a7e This doesn't follow the naming scheme of the other note types. Could we use NT_FDO_PACKAGING_METADATA? > /* Note section name of program property. */ > #define NOTE_GNU_PROPERTY_SECTION_NAME ".note.gnu.property" Reformatted patch attached. Thanks, Mark