unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
To: luca.boccassi@gmail.com
Cc: mark@klomp.org, libc-alpha@sourceware.org
Subject: Re: [PATCH v3] elf: add definition for ELF_NOTE_FDO and NT_FDO_PACKAGING_METADATA note
Date: Mon, 29 Nov 2021 21:35:18 +0100	[thread overview]
Message-ID: <87ilwaem49.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20211126205856.34805-1-luca.boccassi@gmail.com> (luca boccassi's message of "Fri, 26 Nov 2021 20:58:56 +0000")

* luca boccassi:

> From: Luca Boccassi <bluca@debian.org>
>
> As defined on: https://systemd.io/COREDUMP_PACKAGE_METADATA/
> this note will be used starting from Fedora 36.
>
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
> v2: as suggested by Mark, indent comment and add NT_ suffix
> v3: as requested by Florian, add ELF_NOTE_FDO definition
>
>  elf/elf.h | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/elf/elf.h b/elf/elf.h
> index 50f87baceb..baa6c6693e 100644
> --- a/elf/elf.h
> +++ b/elf/elf.h
> @@ -1259,6 +1259,8 @@ typedef struct
>  /* Note entries for GNU systems have this name.  */
>  #define ELF_NOTE_GNU		"GNU"
>  
> +/* Note entries for freedesktop.org have this name.  */
> +#define ELF_NOTE_FDO		"FDO"
>  
>  /* Defined types of notes for Solaris.  */
>  
> @@ -1302,6 +1304,10 @@ typedef struct
>  /* Program property.  */
>  #define NT_GNU_PROPERTY_TYPE_0 5
>  
> +/* Packaging metadata as defined on
> +   https://systemd.io/COREDUMP_PACKAGE_METADATA/ */
> +#define NT_FDO_PACKAGING_METADATA 0xcafe1a7e
> +
>  /* Note section name of program property.   */
>  #define NOTE_GNU_PROPERTY_SECTION_NAME ".note.gnu.property"

I'm going to apply this later this week if no one objects.
(Note that the format of the note payload is very much unlike everything
else we do in the ELF space; see the URL.)

Thanks,
Florian


  reply	other threads:[~2021-11-29 20:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-21 19:39 [PATCH] elf: add definition for FDO_PACKAGING_METADATA note luca.boccassi--- via Libc-alpha
2021-11-22 14:03 ` Florian Weimer via Libc-alpha
2021-11-22 14:44   ` Luca Boccassi via Libc-alpha
2021-11-22 15:17     ` Florian Weimer via Libc-alpha
2021-11-23  9:42       ` Mark Wielaard
2021-11-26 16:49 ` Mark Wielaard
2021-11-26 17:01   ` Luca Boccassi via Libc-alpha
2021-11-26 17:01 ` [PATCH v2] elf: add definition for NT_FDO_PACKAGING_METADATA note luca.boccassi--- via Libc-alpha
2021-11-26 20:27   ` Florian Weimer via Libc-alpha
2021-11-26 20:59     ` Luca Boccassi via Libc-alpha
2021-11-26 20:58 ` [PATCH v3] elf: add definition for ELF_NOTE_FDO and " luca.boccassi--- via Libc-alpha
2021-11-29 20:35   ` Florian Weimer via Libc-alpha [this message]
2021-12-02 22:02   ` Florian Weimer via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ilwaem49.fsf@oldenburg.str.redhat.com \
    --to=libc-alpha@sourceware.org \
    --cc=fweimer@redhat.com \
    --cc=luca.boccassi@gmail.com \
    --cc=mark@klomp.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).